From derby-dev-return-118940-archive-asf-public=cust-asf.ponee.io@db.apache.org Sun May 13 23:25:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id E00D318076D for ; Sun, 13 May 2018 23:25:04 +0200 (CEST) Received: (qmail 30965 invoked by uid 500); 13 May 2018 21:25:03 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 30955 invoked by uid 99); 13 May 2018 21:25:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 13 May 2018 21:25:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 2C1C1180416 for ; Sun, 13 May 2018 21:25:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.311 X-Spam-Level: X-Spam-Status: No, score=-110.311 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id fvR-yS_bsO2o for ; Sun, 13 May 2018 21:25:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 9B1785F58F for ; Sun, 13 May 2018 21:25:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C7860E0F75 for ; Sun, 13 May 2018 21:25:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 31B66217A4 for ; Sun, 13 May 2018 21:25:00 +0000 (UTC) Date: Sun, 13 May 2018 21:25:00 +0000 (UTC) From: "Rick Hillegas (JIRA)" To: derby-dev@db.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DERBY-6945) Re-package Derby as a collection of jigsaw modules MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DERBY-6945?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1647= 3638#comment-16473638 ]=20 Rick Hillegas commented on DERBY-6945: -------------------------------------- Attaching derby-6945-36-aa-moduleDescriptorsForLocaleJars.diff. This patch = adds module descriptors for all of the message localization jars. The patch also eliminates the classes/locales directory and replaces it wit= h a separate classes/locale_xx_YY directory for each message jar file. This= means that you need to add these directories to your classpath if you want= to run Derby from classes rather than jar files. Here are the directories = which you need to add to the classpath for such a configuration: {noformat} classes/client classes/drda classes/engine classes/optional classes/run classes/shared classes/testing classes/tools classes/locale_cs classes/locale_de_DE classes/locale_en classes/locale_es classes/locale_fr classes/locale_hu classes/locale_it classes/locale_ja_JP classes/locale_ko_KR classes/locale_pl classes/locale_pt_BR classes/locale_ru classes/locale_zh_CN classes/locale_zh_TW {noformat} Tests passed cleanly for me with this patch. Touches the following files: {noformat} ------------------- M tools/ant/properties/dirs.properties A java/locales A java/locales/module-info.template Generate module descriptors for all of the message localization jars. ------------------- M build.xml M java/tools/build.xml M java/engine/org/apache/derby/loc/build.xml Adjust the build scripts to account for the new subdirectories of the maste= r classes directory. {noformat} > Re-package Derby as a collection of jigsaw modules > -------------------------------------------------- > > Key: DERBY-6945 > URL: https://issues.apache.org/jira/browse/DERBY-6945 > Project: Derby > Issue Type: Improvement > Affects Versions: 10.13.1.2 > Reporter: Rick Hillegas > Priority: Major > Attachments: derby-6945-01-aa-remove_derbyPreBuild_dep.diff, derb= y-6945-02-ab-newDerbySharedJar.diff, derby-6945-02-ac-newDerbySharedJar.dif= f, derby-6945-03-aa-partitionTest.diff, derby-6945-04-aa-moveRunClass.diff,= derby-6945-05-aa-removeRedundant_Attribute_SQLState.diff, derby-6945-06-aa= -removeOtherSharedDuplicates.diff, derby-6945-07-aa-net_client_overlap.diff= , derby-6945-08-aa-move_shared_iapi_under_shared.diff, derby-6945-08-ab-mov= e_shared_iapi_under_shared.diff, derby-6945-08-ad-move_shared_iapi_under_sh= ared.diff, derby-6945-09-ab-moveInternalDriver.diff, derby-6945-10-aa-moveD= river42.diff, derby-6945-11-ab-moveAutoloadedDriver.diff, derby-6945-12-ab-= moveClientDataSourceInterface.diff, derby-6945-13-aa-create-ClientAutoloade= dDriver.diff, derby-6945-14-aa-moveMoreEmbeddedClassesOutOfPublicAPI.diff, = derby-6945-15-aa-moveMoreClientClassesOutOfPublicAPI.diff, derby-6945-16-aa= -consolidatePublicAPI.diff, derby-6945-17-aa-resealPackagesIn-derbyshared.d= iff, derby-6945-18-aa-resealLocalizationPackage.diff, derby-6945-19-ad-move= PublicAPIintoToolsJar.diff, derby-6945-20-aa-removeClasslister.diff, derby-= 6945-21-aa-simplifyBuildScripts.diff, derby-6945-21-ab-simplifyBuildScripts= .diff, derby-6945-22-ad-isolateClassesByArtifact.diff, derby-6945-22-ae-iso= lateClassesByArtifact.diff, derby-6945-22-af-isolateClassesByArtifact.diff,= derby-6945-23-aa-upgradeToAnt_1.10.2.diff, derby-6945-24-aa-fixNativeAuthe= nticationServiceTest.diff, derby-6945-25-ab-moduleDescriptors.diff, derby-6= 945-26-aa-packagePrivateTests.diff, derby-6945-27-aa-adjustModulesForTests.= diff, derby-6945-28-aa-testingModuleDescriptor.diff, derby-6945-29-aa-disab= le-SimpleApp-test.diff, derby-6945-30-ab-move-clientmessages-toolsmessages.= diff, derby-6945-31-aa-clientmessages-ResourceBundleProvider.diff, derby-69= 45-32-aa-messageLookupCleanup.diff, derby-6945-33-ab-moveLocalizations.diff= , derby-6945-34-aa-licenseHeaders.diff, derby-6945-35-aa-removeSpuriousChar= acter.diff, derby-6945-36-aa-moduleDescriptorsForLocaleJars.diff, derby-694= 5-XX-moveDataSourceFactories, jdeps.out.tar, weirdAnt.out > > > Once we commit to building with Java 9 (see DERBY-6856), we should consid= er re-packaging Derby as a set of jigsaw modules. This would result in a di= fferent set of release artifacts. This might be a good opportunity to addre= ss the Tomcat artifactory issues raised by issue DERBY-6944. -- This message was sent by Atlassian JIRA (v7.6.3#76005)