db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bryan Pendleton (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-6968) Instability in DatabaseMetaDataTest.testGetBestRowIdentifier
Date Sun, 08 Oct 2017 20:14:00 GMT

    [ https://issues.apache.org/jira/browse/DERBY-6968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16196319#comment-16196319

Bryan Pendleton commented on DERBY-6968:

That patch looks fine to me, thanks for taking care of this. +1 from me.

Perhaps we should file a separate issue to track the apparent mismatch with the spec (ordering
on SCOPE)?

> Instability in DatabaseMetaDataTest.testGetBestRowIdentifier
> ------------------------------------------------------------
>                 Key: DERBY-6968
>                 URL: https://issues.apache.org/jira/browse/DERBY-6968
>             Project: Derby
>          Issue Type: Bug
>          Components: JDBC, Test
>    Affects Versions:
>            Reporter: Rick Hillegas
>         Attachments: 10.14.1.testResults.0-failures, derby-6968-01-aa-assertUnorderedResultSet.diff
> Ingo reports instabilities in his platform tests of the release candidate.
He sees intermittent failures in DatabaseMetaDataTest.testGetBestRowIdentifier and then subsequent
failures due to poor test case isolation in that test. The test case fails because DatabaseMetaData.getBestRowIdentifier()
sometimes returns rows in a different order than the test expects.
> The JDBC contract for that method does not specify an order for the returned rows. ORDER
BY clauses appear on some but not all the catalog queries in metadata.properties which define
the Derby result.
> I see two ways to address this issue:
> 1) The test could be fixed so that it hand-sorts the returned rows in order to guarantee
deterministic results.
> 2) ORDER BY clauses could be added to all the implicated metadata queries.

This message was sent by Atlassian JIRA

View raw message