Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Date: Thu, 9 Mar 2017 04:22:38 +0000 (UTC)
From: "Bryan Pendleton (JIRA)" <jira@apache.org>
To: derby-dev@db.apache.org
Message-ID: <JIRA.13049037.1488923837000.18808.1489033358074@Atlassian.JIRA>
In-Reply-To: <JIRA.13049037.1488923837000@Atlassian.JIRA>
References: <JIRA.13049037.1488923837000@Atlassian.JIRA> <JIRA.13049037.1488923837237@jira-lw-us.apache.org>
Subject: [jira] [Commented] (DERBY-6925) Bug in derby_common.sh
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 09 Mar 2017 04:22:43 -0000


    [ https://issues.apache.org/jira/browse/DERBY-6925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15902454#comment-15902454 ] 

Bryan Pendleton commented on DERBY-6925:
----------------------------------------

As of DERBY-3207, derby_common.sh is not directly part of the release.

However, the contents of that file are present in the other scripts, e.g., bin/startNetworkServer contains:
{code}
if [ \( "`expr $SHELL : '.*sh.exe$'`" -gt 0 \) -a \( "$cygwin" = "false" \) ]; then
  LOCALCLASSPATH=`echo $LOCALCLASSPATH | sed -E 's/([\d\w]*):([\d\w]*)/\1;\2/g'`
fi
{code}

The Derby build tools construct the release version of the Unix scripts in the
bin directory by including the contents of the derby_common.sh script inside the
containing scripts, that is what was done by DERBY-3207.

I still don't understand what the particular problem is with quotes on your system,
nor do I understand what you think would be an improvement to these scripts.

Please clarify, if you can.

> Bug in derby_common.sh
> ----------------------
>
>                 Key: DERBY-6925
>                 URL: https://issues.apache.org/jira/browse/DERBY-6925
>             Project: Derby
>          Issue Type: Bug
>            Reporter: Eli Barzilay
>            Priority: Minor
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> At the end of the `derby_common.sh` file, as I currently see in the GH
> mirror:
>     https://github.com/apache/derby/blob/trunk/bin/templates/derby_common.sh#L166
> there is an unquoted use of $SHELL which should really be quoted.  We
> have run into this bug trying to start the server in a docker image,
> with a setup that has no SHELL variable, which results in a syntax
> error.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)