db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bryan Pendleton (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-6391) remove unneeded object creation in newException() calls in releases > 10.10
Date Sun, 31 Jul 2016 01:48:20 GMT

    [ https://issues.apache.org/jira/browse/DERBY-6391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15400903#comment-15400903

Bryan Pendleton commented on DERBY-6391:

Thanks for the careful checking of the code, it is very helpful!

It sounds like we should close this issue, and mark it fixed by 1742858; do you feel that
is appropriate?

> remove unneeded object creation in newException() calls in releases > 10.10
> ---------------------------------------------------------------------------
>                 Key: DERBY-6391
>                 URL: https://issues.apache.org/jira/browse/DERBY-6391
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL, Store
>    Affects Versions:
>            Reporter: Mike Matrigali
>            Assignee: Danoja Dias
>              Labels: derby_backport_reject_10_10
>         Attachments: Derby-6391.diff
> In releases after 10.10 the code has been converted to use new 
> java language features.  One of the benefits I just noticed is that
> arguments to StandardException.newException() no longer have
> to be Objects.  I believe this is due to reimplementation using varargs.
> As an example old code use to have to be written as:
> throw StandardException.newException(
>                     SQLState.FILE_BAD_CHECKSUM,
>                     id,
>                     new Long(checksum.getValue()),
>                     new Long(onDiskChecksum),
>                     pagedataToHexDump(pageData));
> The only reason for the new Long() calls was to make them Objects so
> that the call would match up to a hard coded N Object arg version of
> the newException call.  I believe these conversions to Objects are no
> longer needed (but formatting of the args might change).
> There may be code size savings to be had by doing this code
> rototil.
> Anyone see a downside to changing the code in this way?

This message was sent by Atlassian JIRA

View raw message