Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Date: Fri, 26 Feb 2016 17:01:18 +0000 (UTC)
From: "Bryan Pendleton (JIRA)" <jira@apache.org>
To: derby-dev@db.apache.org
Message-ID: <JIRA.12944600.1456427086000.157339.1456506078201@Atlassian.JIRA>
In-Reply-To: <JIRA.12944600.1456427086000@Atlassian.JIRA>
References: <JIRA.12944600.1456427086000@Atlassian.JIRA>
 <JIRA.12944600.1456427086045@arcas>
Subject: [jira] [Comment Edited] (DERBY-6875) Partially broken download
 pages
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/DERBY-6875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169225#comment-15169225 ] 

Bryan Pendleton edited comment on DERBY-6875 at 2/26/16 5:01 PM:
-----------------------------------------------------------------

AIUI, those *.cgi/*.html pages have been generated by a Derby build tool

    trunk/java/build/org/apache/derbyBuild/ReleaseNotesTransformer.java

Indeed, that tool has the hard-coded boilerplate for the CGI scripts just
as you noted it, with XML comments surrounding all the square-bracketed stuff.

So, it seems like there are two parts to this issue:

1) We need to manually edit the 10.11/10.12 html pages for the older releases to remove 
    the XML comments so that the older releases return to picking up mirrors
   successfully

2) We need to change ReleaseNotesTransformer.java to emit the generated
   html page without the XML comments, so that future download pages will
   be generated correctly.

It looks like our overall release documentation at http://wiki.apache.org/db-derby/ReleasePublication
is correct, although it seems to document all releases starting with 10.7 as
having a certain approach for their download pages, when in fact it appears
that there were 3 conventions that we used:
- 10.6 and older releases used one technique
- 10.7 through 10.10 used a different technique
- 10.11 and 10.12 use yet a 3rd technique (paired *.cgi/*.html pages). 

So perhaps there should be a third sub-task:

3) Revise the ReleasePublication documentation to be clearer. Nobody will
   be producing any new releases of Derby 10.6 or earlier releases, and 
   probably not of 10.7 through 10.10 releases either, so we
   can simplify the instructions by just describing the *current* release process.


was (Author: bryanpendleton):
AIUI, those *.cgi pages have been generated by a Derby build tool

    trunk/java/build/org/apache/derbyBuild/ReleaseNotesTransformer.java

Indeed, that tool has the hard-coded boilerplate for the CGI scripts just
as you noted it, with XML comments surrounding all the square-bracketed stuff.

So, it seems like there are two parts to this issue:

1) We need to manually edit the pages for the older releases to remove 
    the XML comments so that the older releases return to picking up mirrors
   successfully

2) We need to change ReleaseNotesTransformer.java to emit the generated
   CGI page without the XML comments, so that future download pages will
   be generated correctly.

It looks like our overall release documentation at http://wiki.apache.org/db-derby/ReleasePublication
is correct. Perhaps there should be a third sub-task, though:

3) Revise the ReleasePublication documentation to be clearer. Nobody will
   be producing any new releases of Derby 10.6 or earlier releases, so we
   can simplify the instructions by just describing the *current* release process.

> Partially broken download pages
> -------------------------------
>
>                 Key: DERBY-6875
>                 URL: https://issues.apache.org/jira/browse/DERBY-6875
>             Project: Derby
>          Issue Type: Bug
>         Environment: http://db.apache.org/derby/releases/release-10.12.1.1.cgi
> http://db.apache.org/derby/releases/release-10.11.1.1.cgi
>            Reporter: Sebb
>         Attachments: site.diff, tool.diff, xdocs.diff
>
>
> The download pages have a box for choosing a mirror.
> However this is broken - it does not contain a list of mirrors.
> This is because the HTML pages are broken.
> They should contain something like the following from
> http://tomcat.apache.org/download-90.html
> {code}
> <form action="[location]" method="get" id="SelectMirror">
> <p>
>        Other mirrors: <select name="Preferred">
>          [if-any http]
>            [for http]<option value="[http]">[http]</option>[end]
>          [end]
>          [if-any ftp]
>            [for ftp]<option value="[ftp]">[ftp]</option>[end]
>          [end]
>          [if-any backup]
>            [for backup]<option value="[backup]">[backup] (backup)</option>[end]
>            [end]
>          </select><input type="submit" value="Change">
> </p>
> </form>
> {code}
> However they contain:
> {code}
> <form action="[location]" method="get" id="SelectMirror">Other mirrors: <select name="Preferred">
> <!--[if-any http] [for http]--><option value="[http]">[http]</option>
> <!--[end] [end]-->
> <!--[if-any ftp] [for ftp]--><option value="[ftp]">[ftp]</option>
> <!--[end] [end]-->
> <!--[if-any backup] [for backup]--><option value="[backup]">[backup] (backup)</option>
> <!--[end] [end]--></select> <input type="submit" value="Change">
> </form>
> {code}
> The required templating code has been commented out, so does not work.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)