Return-Path: 
 <derby-dev-return-114176-apmail-db-derby-dev-archive=db.apache.org@db.apache.org>
X-Original-To: apmail-db-derby-dev-archive@www.apache.org
Delivered-To: apmail-db-derby-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 0AB0317335
	for <apmail-db-derby-dev-archive@www.apache.org>;
 Thu, 30 Oct 2014 19:31:35 +0000 (UTC)
Received: (qmail 1385 invoked by uid 500); 30 Oct 2014 19:31:34 -0000
Delivered-To: apmail-db-derby-dev-archive@db.apache.org
Received: (qmail 1359 invoked by uid 500); 30 Oct 2014 19:31:34 -0000
Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:derby-dev-help@db.apache.org>
List-Unsubscribe: <mailto:derby-dev-unsubscribe@db.apache.org>
List-Post: <mailto:derby-dev@db.apache.org>
List-Id: <derby-dev.db.apache.org>
Reply-To: <derby-dev@db.apache.org>
Delivered-To: mailing list derby-dev@db.apache.org
Received: (qmail 1345 invoked by uid 99); 30 Oct 2014 19:31:34 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 Oct 2014 19:31:34 +0000
Date: Thu, 30 Oct 2014 19:31:34 +0000 (UTC)
From: "Myrna van Lunteren (JIRA)" <jira@apache.org>
To: derby-dev@db.apache.org
Message-ID: <JIRA.12693801.1391736877000.375487.1414697494790@Atlassian.JIRA>
In-Reply-To: <JIRA.12693801.1391736877000@Atlassian.JIRA>
References: <JIRA.12693801.1391736877000@Atlassian.JIRA>
 <JIRA.12693801.1391736877514@arcas>
Subject: [jira] [Comment Edited] (DERBY-6471) Create a regression test which
 will fail if classes from one Derby jar file leak into another jar file
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/DERBY-6471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14190670#comment-14190670 ] 

Myrna van Lunteren edited comment on DERBY-6471 at 10/30/14 7:31 PM:
---------------------------------------------------------------------

Regarding some of the TODOs:
{code}
- tools/release/build.xml shows that the following files are going into the src distribution:
  <property name="src.tools.includes" value="tools/ant/**,tools/ide/**,tools/j2ee/**,tools/jar/**,tools/java/**,tools/javadoc/**,tools/jdbc4/**,tools/testing/**,tools/l10n/**,tools/release/**"/>
  <property name="src.dirs.includes" value="java/**,plugins/**,bin/**,maven2/**"/>
{code}
  So, the *lastcontents files should automatically be included.
- the current check does not check whether files are missing, so as long as the refreshjardriftcheck target is *not* executed with a jvm that does not support all functionality (for example, with Java 6) and then saved, there is no need to force a check with the highest version. In other words, the build will pass if the initial build & file generation was done to produce the highest set of classes available.
- I've decided it will be cleaner if there is an extra directory level for these lastcontents files. I'll create a directory called 'lastgoodcontents' underneath java/build/org/apache/derbyBuild and submit another patch with that change.


was (Author: myrna):
Regarding some of the TODOs:
- tools/release/build.xml shows that the following files are going into the src distribution:
  <property name="src.tools.includes" value="tools/ant/**,tools/ide/**,tools/j2ee/**,tools/jar/**,tools/java/**,tools/javadoc/**,tools/jdbc4/**,tools/testing/**,tools/l10n/**,tools/release/**"/>
  <property name="src.dirs.includes" value="java/**,plugins/**,bin/**,maven2/**"/>
  So, the *lastcontents files should automatically be included.
- the current check does not check whether files are missing, so as long as the refreshjardriftcheck target is *not* executed with a jvm that does not support all functionality (for example, with Java 6) and then saved, there is no need to force a check with the highest version. In other words, the build will pass if the initial build & file generation was done to produce the highest set of classes available.
- I've decided it will be cleaner if there is an extra directory level for these lastcontents files. I'll create a directory called 'lastgoodcontents' underneath java/build/org/apache/derbyBuild and submit another patch with that change.

> Create a regression test which will fail if classes from one Derby jar file leak into another jar file
> ------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-6471
>                 URL: https://issues.apache.org/jira/browse/DERBY-6471
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>    Affects Versions: 10.11.1.1
>            Reporter: Rick Hillegas
>            Assignee: Myrna van Lunteren
>         Attachments: DERBY-6471.diff, DERBY-6471.stat
>
>
> We should write a test so that we find out early on when a checkin breaks the separation between Derby jar files.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)