db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Myrna van Lunteren (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (DERBY-6471) Create a regression test which will fail if classes from one Derby jar file leak into another jar file
Date Thu, 30 Oct 2014 19:31:34 GMT

    [ https://issues.apache.org/jira/browse/DERBY-6471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14190670#comment-14190670
] 

Myrna van Lunteren edited comment on DERBY-6471 at 10/30/14 7:31 PM:
---------------------------------------------------------------------

Regarding some of the TODOs:
{code}
- tools/release/build.xml shows that the following files are going into the src distribution:
  <property name="src.tools.includes" value="tools/ant/**,tools/ide/**,tools/j2ee/**,tools/jar/**,tools/java/**,tools/javadoc/**,tools/jdbc4/**,tools/testing/**,tools/l10n/**,tools/release/**"/>
  <property name="src.dirs.includes" value="java/**,plugins/**,bin/**,maven2/**"/>
{code}
  So, the *lastcontents files should automatically be included.
- the current check does not check whether files are missing, so as long as the refreshjardriftcheck
target is *not* executed with a jvm that does not support all functionality (for example,
with Java 6) and then saved, there is no need to force a check with the highest version. In
other words, the build will pass if the initial build & file generation was done to produce
the highest set of classes available.
- I've decided it will be cleaner if there is an extra directory level for these lastcontents
files. I'll create a directory called 'lastgoodcontents' underneath java/build/org/apache/derbyBuild
and submit another patch with that change.


was (Author: myrna):
Regarding some of the TODOs:
- tools/release/build.xml shows that the following files are going into the src distribution:
  <property name="src.tools.includes" value="tools/ant/**,tools/ide/**,tools/j2ee/**,tools/jar/**,tools/java/**,tools/javadoc/**,tools/jdbc4/**,tools/testing/**,tools/l10n/**,tools/release/**"/>
  <property name="src.dirs.includes" value="java/**,plugins/**,bin/**,maven2/**"/>
  So, the *lastcontents files should automatically be included.
- the current check does not check whether files are missing, so as long as the refreshjardriftcheck
target is *not* executed with a jvm that does not support all functionality (for example,
with Java 6) and then saved, there is no need to force a check with the highest version. In
other words, the build will pass if the initial build & file generation was done to produce
the highest set of classes available.
- I've decided it will be cleaner if there is an extra directory level for these lastcontents
files. I'll create a directory called 'lastgoodcontents' underneath java/build/org/apache/derbyBuild
and submit another patch with that change.

> Create a regression test which will fail if classes from one Derby jar file leak into
another jar file
> ------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-6471
>                 URL: https://issues.apache.org/jira/browse/DERBY-6471
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>    Affects Versions: 10.11.1.1
>            Reporter: Rick Hillegas
>            Assignee: Myrna van Lunteren
>         Attachments: DERBY-6471.diff, DERBY-6471.stat
>
>
> We should write a test so that we find out early on when a checkin breaks the separation
between Derby jar files.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message