db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-2051) CachedItem's comments and code are inconsistent wrt. syncronization
Date Wed, 17 Sep 2014 11:34:34 GMT

    [ https://issues.apache.org/jira/browse/DERBY-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14137099#comment-14137099
] 

ASF subversion and git services commented on DERBY-2051:
--------------------------------------------------------

Commit 1625521 from [~knutanders] in branch 'code/trunk'
[ https://svn.apache.org/r1625521 ]

DERBY-2051: Remove the unused CachedItem class

> CachedItem's comments and code are inconsistent wrt. syncronization
> -------------------------------------------------------------------
>
>                 Key: DERBY-2051
>                 URL: https://issues.apache.org/jira/browse/DERBY-2051
>             Project: Derby
>          Issue Type: Improvement
>          Components: Services
>    Affects Versions: 10.2.1.6
>            Reporter: Dyre Tjeldvoll
>            Assignee: Knut Anders Hatlen
>         Attachments: d2051-1a-remove.diff
>
>
> The javadoc comment for CachedItem says that the state should only be accessed by the
CacheManager, and that no synchronization is required. But a subset of the accessors/mutators
are declared synchronized. If synchronization is unnecessary it should be removed to improve
performance. If it is required, this should be properly explained in the comments.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message