db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] [Created] (DERBY-6716) Minor fixes in SystemPrivilegesPermissionTest
Date Wed, 27 Aug 2014 09:04:57 GMT
Knut Anders Hatlen created DERBY-6716:

             Summary: Minor fixes in SystemPrivilegesPermissionTest
                 Key: DERBY-6716
                 URL: https://issues.apache.org/jira/browse/DERBY-6716
             Project: Derby
          Issue Type: Bug
          Components: Test
    Affects Versions:
            Reporter: Knut Anders Hatlen
            Assignee: Knut Anders Hatlen
            Priority: Trivial

I noticed two typos in SystemPrivilegesPermissionTest that reduces the test coverage ever
so slightly.

1) assertEquivalentPermissions() checks if two permissions, p1 and p2, are equal. One of the
checks is supposed to be that p1 implies p2 and p2 implies p1. Instead of checking that both
holds, it checks that p1 implies p2 twice.

2) testSystemPermission() does some work to reorder expected actions to match the canonical
action order before calling assertEquals(). However, assertEquals() is only called if the
actions didn't have to be reordered. The assert could have been called unconditionally.

This message was sent by Atlassian JIRA

View raw message