Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Date: Fri, 4 Jul 2014 08:14:34 +0000 (UTC)
From: "Knut Anders Hatlen (JIRA)" <jira@apache.org>
To: derby-dev@db.apache.org
Message-ID: <JIRA.12723119.1403527872352.3645.1404461674075@arcas>
In-Reply-To: <JIRA.12723119.1403527872352@arcas>
References: <JIRA.12723119.1403527872352@arcas>
Subject: [jira] [Resolved] (DERBY-6634) Improve test coverage of
 SqlXmlUtil.java
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/DERBY-6634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Knut Anders Hatlen resolved DERBY-6634.
---------------------------------------

       Resolution: Fixed
    Fix Version/s: 10.11.0.0

Resolving the issue. The only code that's not covered in the SqlXmlUtil class now, is:
- catch blocks that are supposed to detect that the JAXP implementation is missing or broken
- methods that are required by ErrorHandler and NamespaceContext interfaces, but that I cannot find a way to exercise (I suspect we might need to support XMLVALIDATE and namespaces in XPath queries before all of these can be reached)

> Improve test coverage of SqlXmlUtil.java
> ----------------------------------------
>
>                 Key: DERBY-6634
>                 URL: https://issues.apache.org/jira/browse/DERBY-6634
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>    Affects Versions: 10.11.0.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>            Priority: Minor
>             Fix For: 10.11.0.0
>
>         Attachments: d6634-1a-dead-code.diff, d6634-2a-more-tests.diff, d6634-3a-impossible-paths.diff
>
>
> The test coverage report for SqlXmlUtil indicates that we don't have tests for:
> - recompilation of XML queries used in triggers (the code looks dead, and can probably be removed)
> - serialization of sequences of atomic values returned by an XPath query (as far as I can see, we only support single atomic values and sequences of documents, so probably that's also code that can be removed, possibly replaced by an assert)
> - XMLEXISTS operations where the XPath query returns a scalar (after DERBY-6624, it will take the same code path as a query that returns a non-empty sequence, so it won't show up in the report anymore, but it's still useful to have a test case for it)
> - XMLQUERY operations where the XPath query returns a boolean (after DERBY-6624, the same code path will be taken for all data types, so it won't show up in the report anymore, but it's still useful to have a test case for it)


--
This message was sent by Atlassian JIRA
(v6.2#6252)