Return-Path: X-Original-To: apmail-db-derby-dev-archive@www.apache.org Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3537811001 for ; Thu, 3 Jul 2014 12:04:25 +0000 (UTC) Received: (qmail 68019 invoked by uid 500); 3 Jul 2014 12:04:25 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 67988 invoked by uid 500); 3 Jul 2014 12:04:25 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 67972 invoked by uid 99); 3 Jul 2014 12:04:25 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Jul 2014 12:04:25 +0000 Date: Thu, 3 Jul 2014 12:04:24 +0000 (UTC) From: "Dag H. Wanvik (JIRA)" To: derby-dev@db.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (DERBY-6590) Make JUnit tests run the fixtures in a deterministic order. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DERBY-6590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14051364#comment-14051364 ] Dag H. Wanvik edited comment on DERBY-6590 at 7/3/14 12:02 PM: --------------------------------------------------------------- Thanks, Knut. That's a good improvement. In fact, I removed TestConfiguration.orderedSuite altogether, replacing it with the new class. Patch [^derby-6590-2.diff], re-running regressions. was (Author: dagw): Thanks, Knut. That's a good improvement. In fact, I removed TestConfiguration.orderedSuite altogether, replacing it with the new class. > Make JUnit tests run the fixtures in a deterministic order. > ----------------------------------------------------------- > > Key: DERBY-6590 > URL: https://issues.apache.org/jira/browse/DERBY-6590 > Project: Derby > Issue Type: Improvement > Reporter: Dag H. Wanvik > Assignee: Dag H. Wanvik > Attachments: derby-6590-1.diff > > > Since JDK 7, when we use the standard decorator for JUnit tests, e.g. > return TestConfiguration.defaultSuite(AggBuiltinTest.class); > the order in which the test fixtures get run is indeterministic. This is undesirable because it doesn't add much coverage to the product and makes the tests more brittle than they need to be. > We should use TestConfiguration#orderedSuite instead. -- This message was sent by Atlassian JIRA (v6.2#6252)