db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dag H. Wanvik (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (DERBY-6674) Cleanup brittle code in ValidateCheckConstraintResultSet
Date Thu, 31 Jul 2014 18:33:42 GMT

    [ https://issues.apache.org/jira/browse/DERBY-6674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14081239#comment-14081239
] 

Dag H. Wanvik edited comment on DERBY-6674 at 7/31/14 6:33 PM:
---------------------------------------------------------------

Attaching a patch [^derby-6674.diff] for refactoring this. For the non deferrable case, this
adds a single extra method call to the loop control. Hopefully this is acceptable.



was (Author: dagw):
Attaching a patch [^derby-6674.diff] ]for refactoring this. For the non deferrable case, this
adds a single extra method call to the loop control. Hopefully this is acceptable.


> Cleanup brittle code in ValidateCheckConstraintResultSet
> --------------------------------------------------------
>
>                 Key: DERBY-6674
>                 URL: https://issues.apache.org/jira/browse/DERBY-6674
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 10.11.0.0
>            Reporter: Rick Hillegas
>            Assignee: Dag H. Wanvik
>         Attachments: derby-6674.diff
>
>
> The getNextRowCore() method of ValidateCheckConstraintResultSet is an almost exact cut-and-paste
copy of the method it overrides in its superclass. This code should be re-factored to reduce
the cut-and-paste brittleness. This was discovered while investigating DERBY-6665.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message