db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dag H. Wanvik (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-6674) Cleanup brittle code in ValidateCheckConstraintResultSet
Date Thu, 31 Jul 2014 17:23:38 GMT

    [ https://issues.apache.org/jira/browse/DERBY-6674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14081149#comment-14081149
] 

Dag H. Wanvik commented on DERBY-6674:
--------------------------------------

Yes, I was aware of this redundancy. I didn't refactor it yet for fear of a) possible performance
impact for the non deferrable constraints code path, and b) I wasn't sure how much of the
code I could remove for the simplified use case of getNextRowCore for ValidateCheckConstraintResultSet
relative to the general getNextRowCore for TableSCanResultSet. Still, it would be good if
we could find a non-impacting way to avoid the redundancy.


> Cleanup brittle code in ValidateCheckConstraintResultSet
> --------------------------------------------------------
>
>                 Key: DERBY-6674
>                 URL: https://issues.apache.org/jira/browse/DERBY-6674
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 10.11.0.0
>            Reporter: Rick Hillegas
>
> The getNextRowCore() method of ValidateCheckConstraintResultSet is an almost exact cut-and-paste
copy of the method it overrides in its superclass. This code should be re-factored to reduce
the cut-and-paste brittleness. This was discovered while investigating DERBY-6665.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message