db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (DERBY-6626) Check type of user-supplied modules before creating instances
Date Fri, 04 Jul 2014 07:08:34 GMT

     [ https://issues.apache.org/jira/browse/DERBY-6626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Knut Anders Hatlen updated DERBY-6626:

    Attachment: d6626-2a.diff

The attached patch [^d6626-2a.diff] adds explicit checks to verify that the derby.language.sequence.preallocator
property implements SequencePreallocator, and that user-supplied JDBC driver names and DataSource
class names given to ij and dblook are of the correct type.

All regression tests ran cleanly with the patch.

> Check type of user-supplied modules before creating instances
> -------------------------------------------------------------
>                 Key: DERBY-6626
>                 URL: https://issues.apache.org/jira/browse/DERBY-6626
>             Project: Derby
>          Issue Type: Improvement
>          Components: Miscellaneous
>    Affects Versions:
>            Reporter: Knut Anders Hatlen
>         Attachments: d6626-1a-encryptionProvider.diff, d6626-2a.diff
> Derby allows users to specify names of classes to use for various pluggable modules.
> In some cases, it verifies that the class implements the expected interface before it
creates an instance of the class. For example in SpecificAuthenticactionServiceImpl:
> {code}
> 			Class sasClass = Class.forName(specificAuthenticationScheme);
> 			if (!UserAuthenticator.class.isAssignableFrom(sasClass)) {
> 				throw StandardException.newException(SQLState.AUTHENTICATION_NOT_IMPLEMENTED,
> 					specificAuthenticationScheme, "org.apache.derby.authentication.UserAuthenticator");
> 			}
> 			UserAuthenticator aScheme = (UserAuthenticator) sasClass.newInstance();
> {code}
> In other cases, it creates an instance without checking, and instead fails with a ClassCastException
or some other exception when trying to use the instance of the incorrect type. Examples: Java5SystemProcedures
SYSCS_REGISTER_TOOL(), JCECipherFactory, SequenceUpdater.makePreallocator().
> I think it would be good to have similar checks in these other cases too. That'll give
clearer error messages which explain what the problem is, and it will be safer because it
limits which constructors the users can force the Derby engine to invoke.

This message was sent by Atlassian JIRA

View raw message