Return-Path: X-Original-To: apmail-db-derby-dev-archive@www.apache.org Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F18B9117DA for ; Mon, 9 Jun 2014 14:18:01 +0000 (UTC) Received: (qmail 79427 invoked by uid 500); 9 Jun 2014 14:18:01 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 79394 invoked by uid 500); 9 Jun 2014 14:18:01 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 79386 invoked by uid 99); 9 Jun 2014 14:18:01 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Jun 2014 14:18:01 +0000 Date: Mon, 9 Jun 2014 14:18:01 +0000 (UTC) From: "Rick Hillegas (JIRA)" To: derby-dev@db.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Closed] (DERBY-6603) Make LuceneSupport.createOrRecreateIndex() write the index properties file once per indexing run MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DERBY-6603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rick Hillegas closed DERBY-6603. -------------------------------- Resolution: Duplicate Closing this as a duplicate of DERBY-6597. > Make LuceneSupport.createOrRecreateIndex() write the index properties file once per indexing run > ------------------------------------------------------------------------------------------------ > > Key: DERBY-6603 > URL: https://issues.apache.org/jira/browse/DERBY-6603 > Project: Derby > Issue Type: Improvement > Components: SQL > Reporter: Rick Hillegas > > That method re-writes the index properties file for every row read from the table/view, rather than once per table/view. The following line should be moved out of the loop at the end of the method: > {noformat} > writeIndexProperties( propertiesFile, indexProperties ); > {noformat} > I don't think that writing the file for every row is a correctness problem. It's just inefficient and unnecessary. -- This message was sent by Atlassian JIRA (v6.2#6252)