db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-6552) The public api includes methods inherited from superclasses which aren't in the public api and so have no javadoc comments
Date Fri, 13 Jun 2014 11:05:02 GMT

    [ https://issues.apache.org/jira/browse/DERBY-6552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14030496#comment-14030496
] 

Knut Anders Hatlen commented on DERBY-6552:
-------------------------------------------

I think the suggested approach is fine.

Is it an alternative to move all methods from ClientBaseDataSourceRoot into BasicClientDataSource40,
and make ClientBaseDataSource inherit BasicClientDataSource40 instead of ClientBaseDataSourceRoot?
Then, I think, we reduce the number of methods that we have to duplicate.

Also, since ClientBaseDataSource only has one direct subclass, we might be able to fold that
class into ClientDataSource and avoid duplicating the Referenceable methods too.

> The public api includes methods inherited from superclasses which aren't in the public
api and so have no javadoc comments
> --------------------------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-6552
>                 URL: https://issues.apache.org/jira/browse/DERBY-6552
>             Project: Derby
>          Issue Type: Bug
>          Components: Javadoc
>    Affects Versions: 10.11.0.0
>            Reporter: Rick Hillegas
>            Assignee: Dag H. Wanvik
>         Attachments: derby-6552-exp.diff, derby-6552-exp.status
>
>
> We simplified and cleaned up the public api in 10.11. Now, however, we've lost the javadoc
for methods which customers may need to use. For instance, ClientDataSource contains a method
called setSsl() which is inherited from ClientBaseDataSourceRoot. But since ClientBaseDataSourceRoot
doesn't appear in the public api, there's no method header comment to consult.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message