db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-6537) StringUtil.fromHexString is used to convert encryptionKey to byte[]
Date Fri, 16 May 2014 10:25:34 GMT

    [ https://issues.apache.org/jira/browse/DERBY-6537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13998810#comment-13998810

ASF subversion and git services commented on DERBY-6537:

Commit 1594937 from [~chaase3] in branch 'docs/trunk'
[ https://svn.apache.org/r1594937 ]

DERBY-6537  StringUtil.fromHexString is used to convert encryptionKey to byte[]

Modified 3 Developer's Guide and 2 Reference Manual topics.

Patch: DERBY-6537.diff

> StringUtil.fromHexString is used to convert encryptionKey to byte[]
> -------------------------------------------------------------------
>                 Key: DERBY-6537
>                 URL: https://issues.apache.org/jira/browse/DERBY-6537
>             Project: Derby
>          Issue Type: Bug
>          Components: Documentation, Services
>    Affects Versions:
>            Reporter: Dyre Tjeldvoll
>            Assignee: Kim Haase
>            Priority: Minor
>             Fix For:
>         Attachments: DERBY-6537.diff, DERBY-6537.stat, DERBY-6537.zip
> The javadoc for StringUtil.fromHexString states that its intended use is to "Convert
a hexidecimal string generated by toHexString() back into a byte array", and that null is
returned if the length of the hex-string is not even. 
> But in JCECipherFactory.init() it is being used to convert the encryptionKey property
string to byte[]. For this usage such a restriction makes no sense, and is confusing as it
is not documented (at least not in the dev guide chapter about encrypting databases).
> For this usage it would be better to use 
> new BigInt(encryptionKey,16).toByteArray() which would not have this restriction. But
even with this change the documentation should probably be updated to state that the value
for the key must be a valid hex-string, as that is what it will be interpreted as. The first
section of the doc should probably also mention that DES is the default algo, and what its
minimum key length requirements are (now you need to look at the section about specifying
an alternate algo, to find that).

This message was sent by Atlassian JIRA

View raw message