db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dag H. Wanvik (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (DERBY-6516) Convert lang/nestedCommit.sql to JUnit NestedCommitTest
Date Thu, 03 Apr 2014 16:10:19 GMT

    [ https://issues.apache.org/jira/browse/DERBY-6516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13958914#comment-13958914
] 

Dag H. Wanvik edited comment on DERBY-6516 at 4/3/14 4:09 PM:
--------------------------------------------------------------

Uploading a second patch (derby-6516-gc) for the intermittent test, which explicitly closes
the lingering result set. From the commit message:
{quote}
DERBY-5616 Convert lang/nestedCommit.sql to JUnit NestedCommitTest
    
    Patch to fix the intermittent error we saw on this issue. The patch
    makes sure we close the result set for the statement 'values
    doConnCommitInt()' when executed inside a stored
    procedure. Previously, it was executed by the stored procedure
    "doConnStmtIntNoRS". We changed that to "doConnStmtInt" since this
    statement does indeed have a result set.
    
    The supporting procedure in Triggers#doConnStmt also had to be fixed a
    bit, since this particular result set closes itself by performing a
    commit inside the store procedure, which led the second ResultSet#next
    to throw XLC16.
    
    With the patch, I do not see the original error even when disabling the
    explicit garbage collection (Java option -XX:+DisableExplicitGC).
{quote}



was (Author: dagw):
Uploading a second patch for the intermittent test, which explicitly closes the lingering
result set. From the commit message:
{quote}
DERBY-5616 Convert lang/nestedCommit.sql to JUnit NestedCommitTest
    
    Patch to fix the intermittent error we saw on this issue. The patch
    makes sure we close the result set for the statement 'values
    doConnCommitInt()' when executed inside a stored
    procedure. Previously, it was executed by the stored procedure
    "doConnStmtIntNoRS". We changed that to "doConnStmtInt" since this
    statement does indeed have a result set.
    
    The supporting procedure in Triggers#doConnStmt also had to be fixed a
    bit, since this particular result set closes itself by performing a
    commit inside the store procedure, which led the second ResultSet#next
    to throw XLC16.
    
    With the patch, I do not see the original error even when disabling the
    explicit garbage collection (Java option -XX:+DisableExplicitGC).
{quote}


> Convert lang/nestedCommit.sql to JUnit NestedCommitTest
> -------------------------------------------------------
>
>                 Key: DERBY-6516
>                 URL: https://issues.apache.org/jira/browse/DERBY-6516
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>            Reporter: Dag H. Wanvik
>            Assignee: Dag H. Wanvik
>            Priority: Minor
>             Fix For: 10.11.0.0
>
>         Attachments: DERBY-6516.diff, DERBY-6516.stat, d6516.diff, derby-6516-gc.diff
>
>
> Uploading a patch to convert this test to JUnit; also wires into lang/_Suite and removed
it from the harness tests.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message