db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-6507) Convert lang/fk_nonSPS.sql to JUnit ForeignKeysNonSpsTest
Date Thu, 13 Mar 2014 11:17:43 GMT

    [ https://issues.apache.org/jira/browse/DERBY-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13933116#comment-13933116
] 

Knut Anders Hatlen commented on DERBY-6507:
-------------------------------------------

Looks good to me. I assume you plan to file a second patch to remove the original test?

In the suite() method, it's easier to use the DatabasePropertyTestSetup.setLockTimeouts()
to set the lock timeout. Although, since the test case doesn't seem to expect to run into
any lock timeouts, it's probably OK to use the default timeout.

> Convert lang/fk_nonSPS.sql to JUnit ForeignKeysNonSpsTest
> ---------------------------------------------------------
>
>                 Key: DERBY-6507
>                 URL: https://issues.apache.org/jira/browse/DERBY-6507
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL, Test
>            Reporter: Dag H. Wanvik
>            Assignee: Dag H. Wanvik
>            Priority: Minor
>         Attachments: derby-6507-1.diff, derby-6507-1.status
>
>
> Before embarking upon deferrable foreign key constraints, I thought I'd convert this
test to JUnit.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message