db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rick Hillegas (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (DERBY-6464) Improve the encapsulation of various compiler classes
Date Fri, 14 Feb 2014 16:03:24 GMT

     [ https://issues.apache.org/jira/browse/DERBY-6464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Rick Hillegas updated DERBY-6464:
---------------------------------

    Attachment: derby-6464-04-ac-ResultSetNode.diff

Attaching derby-6464-04-ac-ResultSetNode.diff. This patch makes the fields of ResultSetNode
private. I am running tests now.


Touches the following files:

M       java/engine/org/apache/derby/impl/sql/compile/ResultSetNode.java
M       java/engine/org/apache/derby/impl/sql/compile/MergeNode.java
M       java/engine/org/apache/derby/impl/sql/compile/FromTable.java
M       java/engine/org/apache/derby/impl/sql/compile/OrderByNode.java
M       java/engine/org/apache/derby/impl/sql/compile/MatchingClauseNode.java
M       java/engine/org/apache/derby/impl/sql/compile/FromSubquery.java
M       java/engine/org/apache/derby/impl/sql/compile/SingleChildResultSetNode.java
M       java/engine/org/apache/derby/impl/sql/compile/NormalizeResultSetNode.java
M       java/engine/org/apache/derby/impl/sql/compile/SelectNode.java
M       java/engine/org/apache/derby/impl/sql/compile/SubqueryNode.java
M       java/engine/org/apache/derby/impl/sql/compile/RowCountNode.java
M       java/engine/org/apache/derby/impl/sql/compile/DistinctNode.java
M       java/engine/org/apache/derby/impl/sql/compile/ProjectRestrictNode.java
M       java/engine/org/apache/derby/impl/sql/compile/GroupByNode.java
M       java/engine/org/apache/derby/impl/sql/compile/DeleteNode.java
M       java/engine/org/apache/derby/impl/sql/compile/UnionNode.java
M       java/engine/org/apache/derby/impl/sql/compile/UpdateNode.java
M       java/engine/org/apache/derby/impl/sql/compile/WindowResultSetNode.java
M       java/engine/org/apache/derby/impl/sql/compile/JoinNode.java
M       java/engine/org/apache/derby/impl/sql/compile/FromVTI.java
M       java/engine/org/apache/derby/impl/sql/compile/MaterializeResultSetNode.java
M       java/engine/org/apache/derby/impl/sql/compile/RowResultSetNode.java
M       java/engine/org/apache/derby/impl/sql/compile/FromBaseTable.java
M       java/engine/org/apache/derby/impl/sql/compile/CurrentOfNode.java
M       java/engine/org/apache/derby/impl/sql/compile/SetOperatorNode.java
M       java/engine/org/apache/derby/impl/sql/compile/ScrollInsensitiveResultSetNode.java
M       java/engine/org/apache/derby/impl/sql/compile/HashTableNode.java
M       java/engine/org/apache/derby/impl/sql/compile/IntersectOrExceptNode.java
M       java/engine/org/apache/derby/impl/sql/compile/PredicateList.java
M       java/engine/org/apache/derby/impl/sql/compile/IndexToBaseRowNode.java
M       java/engine/org/apache/derby/impl/sql/compile/TableOperatorNode.java
M       java/engine/org/apache/derby/impl/sql/compile/HalfOuterJoinNode.java


> Improve the encapsulation of various compiler classes
> -----------------------------------------------------
>
>                 Key: DERBY-6464
>                 URL: https://issues.apache.org/jira/browse/DERBY-6464
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 10.11.0.0
>            Reporter: Rick Hillegas
>            Assignee: Rick Hillegas
>         Attachments: derby-6464-01-aa-makeFieldsPrivate.diff, derby-6464-02-aa-fixJavadoc.diff,
derby-6464-03-aa-morePrivateFields.diff, derby-6464-04-ac-ResultSetNode.diff
>
>
> These classes have a lot of package visible fields. This makes it hard to reason about
how they are being used. This issue tracks some improvements to the encapsulation of these
classes.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message