db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Myrna van Lunteren (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-6426) Fix isLoginException
Date Wed, 05 Feb 2014 22:46:11 GMT

    [ https://issues.apache.org/jira/browse/DERBY-6426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13892702#comment-13892702
] 

Myrna van Lunteren commented on DERBY-6426:
-------------------------------------------

The origin of the odd code is from DERBY-5427, revision http://svn.apache.org/viewvc?view=revision&revision=1183503.

I think it is OK to backport.

>From code review, I'm making the following conclusions:
With the new code, we only return 'true' if the SQLState is LOGIN_FAILED, and then we do not
want a core dump, where before we would do this with all StandardExceptions.
But, now, with other SQLStates, we return 'false', causing a java core dump.
But because we always already got an error, I think this is ok.

I don't think this warrants a release note, the only thing I can think of is that users would
possibly get a lot of java core dump files if they hit other errors on login, but that seems
to be the sort of situation you would want those files.

I'll backport to 10.10.

> Fix isLoginException
> --------------------
>
>                 Key: DERBY-6426
>                 URL: https://issues.apache.org/jira/browse/DERBY-6426
>             Project: Derby
>          Issue Type: Improvement
>          Components: JDBC
>    Affects Versions: 10.9.1.0
>            Reporter: Dave Brosius
>            Assignee: Dave Brosius
>            Priority: Trivial
>             Fix For: 10.1.3.2
>
>         Attachments: fix_isLoginException.txt
>
>
> code treats any StandardException as a login exception due to curious no-op code. Added
login state check to make it work as expected.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message