Return-Path: X-Original-To: apmail-db-derby-dev-archive@www.apache.org Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1317D10202 for ; Thu, 9 Jan 2014 20:07:52 +0000 (UTC) Received: (qmail 15570 invoked by uid 500); 9 Jan 2014 20:07:51 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 15391 invoked by uid 500); 9 Jan 2014 20:07:50 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 15002 invoked by uid 99); 9 Jan 2014 20:07:50 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Jan 2014 20:07:50 +0000 Date: Thu, 9 Jan 2014 20:07:50 +0000 (UTC) From: "Dag H. Wanvik (JIRA)" To: derby-dev@db.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (DERBY-6453) Remove dead code in InsertResultSet and flag skipCheckConstraints MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DERBY-6453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dag H. Wanvik updated DERBY-6453: --------------------------------- Attachment: cleanup-misc-3.diff Uploading version 3, which improves the trigger/import test case to verify the trigger was actually called. > Remove dead code in InsertResultSet and flag skipCheckConstraints > ----------------------------------------------------------------- > > Key: DERBY-6453 > URL: https://issues.apache.org/jira/browse/DERBY-6453 > Project: Derby > Issue Type: Improvement > Components: SQL > Reporter: Dag H. Wanvik > Assignee: Dag H. Wanvik > Priority: Minor > Attachments: cleanup-misc-2.diff, cleanup-misc-2.stat, cleanup-misc-3.diff, cleanup-misc.diff, cleanup-misc.stat > > > I identified some unused code; a flag that is always false, and code for handling triggers in bulk insert which is unused (by inspection and corroborated by JaCoCo results for our regression tests): we disable bulk insert if there are triggers present, cf. > * DMLModStatementNode#getAllRelevantTriggers -> > adjustDeferredFlag(true) > * InsertResultSet#bulkInsert: > bulkInsert = verifyBulkInsert()-> > : > // bulk insert is disabled for deferred mode inserts > if (constants.deferred) > return false; -- This message was sent by Atlassian JIRA (v6.1.5#6160)