db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-6453) Remove dead code in InsertResultSet and flag skipCheckConstraints
Date Thu, 09 Jan 2014 20:23:52 GMT

    [ https://issues.apache.org/jira/browse/DERBY-6453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867001#comment-13867001
] 

ASF subversion and git services commented on DERBY-6453:
--------------------------------------------------------

Commit 1556938 from [~dagw] in branch 'code/trunk'
[ https://svn.apache.org/r1556938 ]

DERBY-6453 Remove dead code in InsertResultSet and flag skipCheckConstraints

Patch _*cleanup-misc-3*_ which removes dead code but inserts asserts
in sane mode if we should somehow end up with triggers in bulk insert
mode and also removes a boolean variable in some interfaces which was
always called with false: {{skipCheckConstraints}}.
It adds a new test case, {{CheckConstraintTest#testbulkInsert}}.

> Remove dead code in InsertResultSet and flag skipCheckConstraints
> -----------------------------------------------------------------
>
>                 Key: DERBY-6453
>                 URL: https://issues.apache.org/jira/browse/DERBY-6453
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL
>            Reporter: Dag H. Wanvik
>            Assignee: Dag H. Wanvik
>            Priority: Minor
>         Attachments: cleanup-misc-2.diff, cleanup-misc-2.stat, cleanup-misc-3.diff, cleanup-misc.diff,
cleanup-misc.stat
>
>
> I identified some unused code; a flag that is always false, and code for handling triggers
in bulk insert which is unused (by inspection and corroborated by JaCoCo results for our regression
tests): we disable bulk insert if there are triggers present, cf. 
> * DMLModStatementNode#getAllRelevantTriggers ->
>   adjustDeferredFlag(true)
> * InsertResultSet#bulkInsert:
>   bulkInsert = verifyBulkInsert()->
>       :
>       // bulk insert is disabled for deferred mode inserts
>       if (constants.deferred)
>       return false;



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message