db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dag H. Wanvik (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (DERBY-6453) Remove dead code in InsertResultSet and flag skipCheckConstraints
Date Thu, 09 Jan 2014 20:09:50 GMT

    [ https://issues.apache.org/jira/browse/DERBY-6453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13866985#comment-13866985
] 

Dag H. Wanvik edited comment on DERBY-6453 at 1/9/14 8:08 PM:
--------------------------------------------------------------

Uploading version 3, which improves the trigger/import test case to verify the trigger was
actually called, and fixes some too long lines.


was (Author: dagw):
Uploading version 3, which improves the trigger/import test case to verify the trigger was
actually called.

> Remove dead code in InsertResultSet and flag skipCheckConstraints
> -----------------------------------------------------------------
>
>                 Key: DERBY-6453
>                 URL: https://issues.apache.org/jira/browse/DERBY-6453
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL
>            Reporter: Dag H. Wanvik
>            Assignee: Dag H. Wanvik
>            Priority: Minor
>         Attachments: cleanup-misc-2.diff, cleanup-misc-2.stat, cleanup-misc-3.diff, cleanup-misc.diff,
cleanup-misc.stat
>
>
> I identified some unused code; a flag that is always false, and code for handling triggers
in bulk insert which is unused (by inspection and corroborated by JaCoCo results for our regression
tests): we disable bulk insert if there are triggers present, cf. 
> * DMLModStatementNode#getAllRelevantTriggers ->
>   adjustDeferredFlag(true)
> * InsertResultSet#bulkInsert:
>   bulkInsert = verifyBulkInsert()->
>       :
>       // bulk insert is disabled for deferred mode inserts
>       if (constants.deferred)
>       return false;



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message