db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Myrna van Lunteren (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-3955) test lang/selectivity.sql can be revived
Date Mon, 27 Jan 2014 19:28:45 GMT

    [ https://issues.apache.org/jira/browse/DERBY-3955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13883159#comment-13883159
] 

Myrna van Lunteren commented on DERBY-3955:
-------------------------------------------

It seems that this test, when run with a jdk 1.8 (pre release?) is showing a problem:
e.g. http://download.java.net/javadesktop/derby/request_5586696/javadb-task-3791625.html
shows the following stack trace:
junit.framework.AssertionFailedError: expected:<4010> but was:<12913>
	at org.apache.derbyTesting.junit.BaseJDBCTestCase.checkEstimatedRowCount(BaseJDBCTestCase.java:1561)
	at org.apache.derbyTesting.functionTests.tests.lang.SelectivityTest.testStatMatcher(SelectivityTest.java:785)
	at org.apache.derbyTesting.junit.BaseTestCase.runBare(BaseTestCase.java:118)
	at org.apache.derbyTesting.junit.BaseJDBCTestCase.runBareOverridable(BaseJDBCTestCase.java:440)
	at org.apache.derbyTesting.junit.BaseJDBCTestCase.runBare(BaseJDBCTestCase.java:457)
	at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24)
	at junit.extensions.TestSetup$1.protect(TestSetup.java:21)
	at junit.extensions.TestSetup.run(TestSetup.java:25)
	at org.apache.derbyTesting.junit.BaseTestSetup.run(BaseTestSetup.java:57)
	at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24)
	at junit.extensions.TestSetup$1.protect(TestSetup.java:21)
	at junit.extensions.TestSetup.run(TestSetup.java:25)
	at org.apache.derbyTesting.junit.BaseTestSetup.run(BaseTestSetup.java:57)

I think this is related to the fact that the fixtures in the test are run in a different sequence,
i.e. 
jdk1.8:
-----------------
(emb)lang.SelectivityTest.testSingleColumnSelectivity used 296 ms 
(emb)lang.SelectivityTest.testMultiPredicate used 126 ms 
(emb)lang.SelectivityTest.testTwoWayJoins used 26 ms 
(emb)lang.SelectivityTest.testStatMatcher used 254 ms 
(emb)lang.SelectivityTest.testBeetle4321 used 78 ms 
(emb)lang.SelectivityTest.testBasic used 2198 ms 
(emb)lang.SelectivityTest.testThreeWayJoins used 758 ms 
(emb)lang.SelectivityTest.testScratch used 115 ms 
-----------------
my ibm 1.7 run:
-----------------
(emb)lang.SelectivityTest.testSingleColumn used 323 ms .
(emb)lang.SelectivityTest.testMultiPredicate used 184 ms .
(emb)lang.SelectivityTest.testTwoWayJoins used 27 ms .
(emb)lang.SelectivityTest.testThreeWayJoins used 608 ms .
(emb)lang.SelectivityTest.testScratch used 145 ms .
(emb)lang.SelectivityTest.testStatMatcher used 114 ms .
(emb)lang.SelectivityTest.testBeetle4321 used 76 ms .
(emb)lang.SelectivityTest.testBasic used 2830 ms
-----------------
These fixtures should be independent of eachother, I'll look into this.

> test lang/selectivity.sql can be revived
> ----------------------------------------
>
>                 Key: DERBY-3955
>                 URL: https://issues.apache.org/jira/browse/DERBY-3955
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>            Reporter: Myrna van Lunteren
>            Assignee: Myrna van Lunteren
>            Priority: Minor
>         Attachments: DERBY-3955.diff1, DERBY-3955.diff2, DERBY-3955.diff3, derby-3955_sanityCheck_dont_commit_diff.txt,
oldSelectivity.java
>
>
> One test that was contributed during the IBM contribution of derby code was not runnable
at the time - lang/selectivity.sql.
> This test is still there, and I think might have some valuable regression tests if it
gets adapted to the current functionality in Derby.
> Ideally too, it should get converted to junit, or at least be made to run through the
langScripts junit suite.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message