Return-Path: X-Original-To: apmail-db-derby-dev-archive@www.apache.org Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A147910FE8 for ; Mon, 2 Dec 2013 19:04:36 +0000 (UTC) Received: (qmail 23728 invoked by uid 500); 2 Dec 2013 19:04:36 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 23705 invoked by uid 500); 2 Dec 2013 19:04:36 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 23697 invoked by uid 99); 2 Dec 2013 19:04:36 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Dec 2013 19:04:36 +0000 Date: Mon, 2 Dec 2013 19:04:36 +0000 (UTC) From: "Mamta A. Satoor (JIRA)" To: derby-dev@db.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DERBY-6380) Rolling log files do not get copied in failed directory when a junit test fails MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DERBY-6380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13836799#comment-13836799 ] Mamta A. Satoor commented on DERBY-6380: ---------------------------------------- Thanks for working on this jira, Myrna. > Rolling log files do not get copied in failed directory when a junit test fails > ------------------------------------------------------------------------------- > > Key: DERBY-6380 > URL: https://issues.apache.org/jira/browse/DERBY-6380 > Project: Derby > Issue Type: Bug > Components: Test > Affects Versions: 10.11.0.0 > Reporter: Mamta A. Satoor > Assignee: Myrna van Lunteren > Fix For: 10.11.0.0 > > Attachments: DERBY-6380.diff, DERBY-6380.diff_2 > > > DERBY-6350(Provide a rolling file implementation of derby.log) is adding a very useful feature to Derby. To test the feature, I ran the junit suite with rollingFile option as shown below > time java -Dderby.stream.error.style=rollingFile -Dderby.tests.trace=true junit.textui.TestRunner org.apache.derbyTesting.functionTests.suites.All > runall.out 2>&1 > I noticed that even though we are running junit suite with the rollingFile, we still create derby.log(although it was empty) along with expected derby-0.log and so on. I had not expected to see the traditional derby.log when running with rollingFile. In addition, when a test failed, the failed directory had empty derby.log copied but the rolling log files did not get copied. The code changes to copy the rolling log files in case of failure probably need to go into org.apache.derbyTesting.junit.BaseTestCase:runBare() in the "catch (Throwable running) {" section. The log files are crucial to do any test failure debugging and hence should get copied in the failed directory. -- This message was sent by Atlassian JIRA (v6.1#6144)