db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (DERBY-2041) Trigger should register a dependency on tables and columns used in its body
Date Wed, 04 Dec 2013 20:18:35 GMT

     [ https://issues.apache.org/jira/browse/DERBY-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Knut Anders Hatlen updated DERBY-2041:

    Attachment: d2041-2a-upgrade-test.diff

Attaching a patch that adds an upgrade test case that verifies the behaviour on upgrade and

This is the first upgrade test case that creates a view, and that caused some problems for
DatabaseMetaDataTest when it runs as part of the upgrade test suite. The problems happen when
DatabaseMetaDataTest cross checks all rows returned by getColumns() against ResultSetMetaData.getSchemaName()
and ResultSetMetaData.getTableName(). Those checks fail because the RSMD methods return data
for the underlying table and not for the view itself (intentionally, judging by other tests).
The patch avoids these problems by making DatabaseMetaDataTest skip the failing checks for
columns in views.

> Trigger should register a dependency on tables and columns used in its body
> ---------------------------------------------------------------------------
>                 Key: DERBY-2041
>                 URL: https://issues.apache.org/jira/browse/DERBY-2041
>             Project: Derby
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions:
>            Reporter: Bryan Pendleton
>            Assignee: Knut Anders Hatlen
>            Priority: Minor
>              Labels: derby_triage10_11
>             Fix For:
>         Attachments: d2041-1a.diff, d2041-1b.diff, d2041-2a-upgrade-test.diff, register-dependencies.diff,
> A trigger registers a dependency in the Dependency Manager for those columns which cause
the firing of the trigger, but does not register a dependency on tables and columns which
are used in the body of the trigger. This means that the trigger may unexpectedly become invalid
due to a change to one of those tables and columns in its body, and the user may be surprised
that Derby did not warn them of this problem when the underlying table/column change was made.
> An example of this problem is as follows:
> create table t1 (c1 int);
> create table t2 (c2 int);
> create trigger tr1 after update of c1 on t1  for each row mode db2sql insert into t2
(c2) values (1);
> With this set of definitions, Derby will warn/prevent the user about changes to table
t1 and column c1, but will not warn the user about changes to table t2 and column c2. If the
user drops or renames t2 or c2, the trigger will then give an error the next time it fires.
> It seems like it would be an improvement for the trigger to record this dependency on
table t2 and column c2.

This message was sent by Atlassian JIRA

View raw message