db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dag H. Wanvik (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (DERBY-673) Get rid of the NodeFactory
Date Thu, 17 Oct 2013 13:00:42 GMT

     [ https://issues.apache.org/jira/browse/DERBY-673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Dag H. Wanvik resolved DERBY-673.

          Resolution: Fixed
       Fix Version/s:
    Issue & fix info:   (was: Patch Available)

> Get rid of the NodeFactory
> --------------------------
>                 Key: DERBY-673
>                 URL: https://issues.apache.org/jira/browse/DERBY-673
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL
>            Reporter: Rick Hillegas
>            Assignee: Dag H. Wanvik
>              Labels: derby_triage10_11
>             Fix For:
>         Attachments: derby-673-1.diff.gz, derby-673-1.status, derby-673-2.diff.gz, derby-673-2.status,
derby-673-3.diff.gz, derby-673-3.status, derby-673-fixcomments.diff, derby-673-more-typesafe-6.diff,
derby-673-more-typesafe-6.status, derby-673-nuke-ctypes-enum.diff, derby-673-nuke-ctypes-enum.stat,
derby-673-nuke-ctypes-without-enum-2.diff, derby-673-nuke-ctypes-without-enum-2.status, derby-673-nuke-ctypes-without-enum-3.diff,
derby-673-nuke-ctypes-without-enum-3.status, derby-673-nuke-ctypes-without-enum.diff, derby-673-nuke-ctypes-without-enum.status,
derby-673-typesafe-lists-1.diff, derby-673-typesafe-lists-1.status, derby-673-typesafe-lists-2.diff.gz,
derby-673-typesafe-lists-2.status, nodefactory-31.status, nodefactory-31.zip
> This piece of code once had a purpose in life. It was one of the double-joints which
allowed cloudscape to ship with and without compiler support for the synchronization language.
Synchronization has been removed. If we want to plug in optional language components, I think
there are better ways to do this.
> The NodeFactory turned into a big, sprawling piece of code. At some point this code was
slimmed down by telescoping all of its factory methods into a couple unwieldly, weakly-typed
overloads backed by cumbersome logic in the actual node constructors. I would like to reintroduce
strongly typed node constructors which the parser can call directly. This will make node generation
easier to read and less brittle and it will get rid of the now useless NodeFactory class.

This message was sent by Atlassian JIRA

View raw message