db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dave Brosius <dbros...@mebigfatguy.com>
Subject odd o.a.d.i.j.TransactionResourceImpl.isLoginException code
Date Mon, 02 Sep 2013 17:39:25 GMT
It appears that 
org.apache.derby.impl.jdbc.TransactionResourceImpl.isLoginException is 
perhaps missing an if

should

     private boolean isLoginException(Throwable thrownException) {
        if (thrownException instanceof StandardException) {
*((StandardException) 
thrownException).getSQLState().equals(SQLState.LOGIN_FAILED);*
            return true;
        }
        return false;
     }

be


     private boolean isLoginException(Throwable thrownException) {
        if (thrownException instanceof StandardException) {
*if ((StandardException) 
thrownException).getSQLState().equals(SQLState.LOGIN_FAILED)*
               return true;
        }
        return false;
     }


?

Mime
View raw message