Return-Path: X-Original-To: apmail-db-derby-dev-archive@www.apache.org Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4F6E110AAA for ; Fri, 16 Aug 2013 03:53:53 +0000 (UTC) Received: (qmail 2042 invoked by uid 500); 16 Aug 2013 03:53:49 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 2026 invoked by uid 500); 16 Aug 2013 03:53:48 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 2011 invoked by uid 99); 16 Aug 2013 03:53:47 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Aug 2013 03:53:47 +0000 Date: Fri, 16 Aug 2013 03:53:47 +0000 (UTC) From: "Dag H. Wanvik (JIRA)" To: derby-dev@db.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (DERBY-6299) Improve the code coverage of Org.apache.derby.iapi.services.sanity package MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DERBY-6299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13741873#comment-13741873 ] Dag H. Wanvik edited comment on DERBY-6299 at 8/16/13 3:51 AM: --------------------------------------------------------------- Looks good to me. (BTW, the last part of the patch - for sqlgrammar.jj) didn't apply cleanly; patch(1) claimed it was malformed, but I was able to apply it manually.) Btw, in DataDictionaryImpl I see this test: if (re instanceof AssertFailure) which wouldn't have worked before the patch since it tests on the wrapper class, while code throwing AssertFailure uses the wrapped class. With the patch this test would now be correct again. was (Author: dagw): Looks good to me. (BTW, the last part of the patch - for sqlgrammar.sql) didn't apply cleanly; patch(1) claimed it was malformed, but I was able to apply it manually.) Btw, in DataDictionaryImpl I see this test: if (re instanceof AssertFailure) which wouldn't have worked before the patch since it tests on the wrapper class, while code throwing AssertFailure uses the wrapped class. With the patch this test would now be correct again. > Improve the code coverage of Org.apache.derby.iapi.services.sanity package > ---------------------------------------------------------------------------- > > Key: DERBY-6299 > URL: https://issues.apache.org/jira/browse/DERBY-6299 > Project: Derby > Issue Type: Sub-task > Components: Test > Reporter: ahsan shamsudeen > Assignee: ahsan shamsudeen > Priority: Minor > Attachments: bryan.patch, commit.patch, commit.stat, DERBY-6299.patch, DERBY-6299.patch, DERBY-6299.patch > > > According to the coverage reports, All classes in Org.apache.derby.iapi.services.sanity have completely zero coverage. > So this sub-task is to improve code coverage by doing the following. > > 1)Change all the import statements in the code to reference the new location of SanityManager and > AssertFailure > 2) Delete the wrapper classes org.apache.derby.iapi.services.sanity.SanityManager > org.apache.derby.iapi.services.sanity.AssertFailure -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira