db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (DERBY-6318) Simplify setting of possibly null parameters in XPLAIN descriptors
Date Wed, 28 Aug 2013 11:27:52 GMT

     [ https://issues.apache.org/jira/browse/DERBY-6318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Knut Anders Hatlen updated DERBY-6318:

    Attachment: d6318-1a.diff

Attaching d6318-1a.diff which uses setObject() to hide the null checking and conversion from
Number to primitive types.

Running regression tests.
> Simplify setting of possibly null parameters in XPLAIN descriptors
> ------------------------------------------------------------------
>                 Key: DERBY-6318
>                 URL: https://issues.apache.org/jira/browse/DERBY-6318
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions:
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>            Priority: Trivial
>         Attachments: d6318-1a.diff
> I noticed that the various XPLAIN descriptor classes need to set lots of numeric parameters
on a PreparedStatement, using the following idiom to allow null values:
>         if (parse_time != null)
>             ps.setLong(2, parse_time.longValue());
>         else
>             ps.setNull(2, Types.BIGINT);
> The same thing could have been achieved by using a single call to setObject(), like this:
>         ps.setObject(2, parse_time, Types.BIGINT);
> This would make the methods shorter and clearer.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message