db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bryan Pendleton (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (DERBY-6299) Improve the code coverage of Org.apache.derby.iapi.services.sanity package
Date Fri, 16 Aug 2013 02:32:48 GMT

     [ https://issues.apache.org/jira/browse/DERBY-6299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Bryan Pendleton updated DERBY-6299:

    Attachment: commit.stat

I'm getting ready to commit the work that Ahsan has done on this issue.

Attached is commit.patch, the patch we're intending to submit.

Also attached is commit.stat, the 'svn stat' of the changed files.

There is a long list of files, but the change itself is quite simple.

Each of the files has a diff roughly like:


--- java/build/org/apache/derbyBuild/ODBCMetadataGenerator.java	(revision 1508288)

+++ java/build/org/apache/derbyBuild/ODBCMetadataGenerator.java	(working copy)

@@ -31,7 +31,7 @@

 import java.util.HashMap;
 import java.util.ArrayList;
-import org.apache.derby.iapi.services.sanity.SanityManager;
+import org.apache.derby.shared.common.sanity.SanityManager;
  * This class is used at COMPILE TIME ONLY.  It is responsible for generating


In addition to modifying the import statement in 667 .java files, we are
also proposing to delete the two files

D       java\engine\org\apache\derby\iapi\services\sanity\AssertFailure.java
D       java\engine\org\apache\derby\iapi\services\sanity\SanityManager.java

These two files, left over from DERBY-1115, are trivial wrappers around the
same-named classes in o.a.d.shared.common.sanity package.

So all we're doing, then, is following up on DERBY-1115 by fixing the import
statements and removing the two wrapper classes.

So it's a big change, but conceptually quite simple.

If you have a few minutes to look at this patch in the next day or so,
please do so, and let me know of any concerns.



> Improve the code coverage of  Org.apache.derby.iapi.services.sanity  package
> ----------------------------------------------------------------------------
>                 Key: DERBY-6299
>                 URL: https://issues.apache.org/jira/browse/DERBY-6299
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Test
>            Reporter: ahsan shamsudeen
>            Assignee: ahsan shamsudeen
>            Priority: Minor
>         Attachments: bryan.patch, commit.patch, commit.stat, DERBY-6299.patch, DERBY-6299.patch,
> According to the coverage reports, All classes in  Org.apache.derby.iapi.services.sanity
 have completely zero coverage.
> So this sub-task is to improve code coverage by doing the  following.
> 1)Change all the import statements in the code to reference the new location of SanityManager
>    AssertFailure
> 2) Delete the wrapper classes org.apache.derby.iapi.services.sanity.SanityManager
>    org.apache.derby.iapi.services.sanity.AssertFailure

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message