db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bryan Pendleton (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-6291) Improve code coverage of org.apache.derby.iapi.jdbc.BrokeredCallableStatement
Date Wed, 24 Jul 2013 01:07:46 GMT

    [ https://issues.apache.org/jira/browse/DERBY-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13717853#comment-13717853
] 

Bryan Pendleton commented on DERBY-6291:
----------------------------------------

This patch looks quite good to me. The new test cases are clear, and they
accomplish our goal, which is to explicitly verify that the "named parameter"
variants of the CallableStatement interface are not current implemented,
and throw the expected SQLFeatureNotSupportException.

Although the code coverage tools still don't report the coverage as well
as we would like, due to the coverage tool problems we discussed in
DERBY-5854, the coverage report DOES now show coverage for
ClientCallableStatement and EmbedCallableStatement for the named
parameter APIs, which is good.

I think we should proceed with this patch. 
                
> Improve code coverage of  org.apache.derby.iapi.jdbc.BrokeredCallableStatement
> ------------------------------------------------------------------------------
>
>                 Key: DERBY-6291
>                 URL: https://issues.apache.org/jira/browse/DERBY-6291
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC
>            Reporter: ahsan shamsudeen
>            Assignee: ahsan shamsudeen
>            Priority: Minor
>              Labels: derby_triage10_11
>         Attachments: DERBY-6291.patch, FINAL-DERBY.patch, setIntPatch.txt, UPDATED-DERBY-6291.patch
>
>
> According to code coverage analysis, org.apache.derby.iapi.jdbc.BrokeredCallableStatement
is 
> exercised poorly by of our regression tests. The current coverage report for this class
can be found at http://dbtg.foundry.sun.com/derby/test/coverage/_files/a9.html
> This task is to investigate this class, and either remove the unused code, or add
> regression test that exercise the code, as appropriate.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message