db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bryan Pendleton (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-6264) Improve test coverage of org.apache.derby.iapi.db.PropertyInfo
Date Thu, 20 Jun 2013 04:03:22 GMT

    [ https://issues.apache.org/jira/browse/DERBY-6264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13688848#comment-13688848

Bryan Pendleton commented on DERBY-6264:

Hi Ahsan,

I agree, it is not obvious what is best to do here. I think that we should:
1) Leave TestPropertyInfo alone. It is used by several tests, and is not a problem.
    As Myrna pointed out, my initial code search was incomplete and I didn't
    find those references, but I see them now.
2) Remove the 4 unused methods from the PropertyInfo class. As Rick points
   out, they are not part of the Derby public API at this time.

If, at some point in the future, the community wishes to revive the methods
in the PropertyInfo class, they will still be present in the SVN history for us
to go back and review them.

So, can you prepare a patch which removes the 4 unused methods from
PropertyInfo? Here is some good advice about preparing patch proposals:

> Improve test coverage of org.apache.derby.iapi.db.PropertyInfo
> --------------------------------------------------------------
>                 Key: DERBY-6264
>                 URL: https://issues.apache.org/jira/browse/DERBY-6264
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Test
>            Reporter: Bryan Pendleton
>            Assignee: ahsan shamsudeen
>            Priority: Minor
> According to the coverage reports, only 1 of the 5 methods in
> org.apache.derby.iapi.db.PropertyInfo is exercised by the Derby
> regression tests.
> This sub-task is to improve that test coverage.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message