db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bryan Pendleton (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-6264) Improve test coverage of org.apache.derby.iapi.db.PropertyInfo
Date Sat, 15 Jun 2013 17:55:20 GMT

    [ https://issues.apache.org/jira/browse/DERBY-6264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13684247#comment-13684247
] 

Bryan Pendleton commented on DERBY-6264:
----------------------------------------

I am confused about the PropertyInfo class. It is a very old class in the Derby
sources, yet I have never really worked with it.

The only use I can find of this class in the Derby source tree is the built-in
system procedure SYSCS_UTIL.SYSCS_SET_DATABASE_PROPERTY(),
which invokes PropertyInfo.setDatabaseProperty.

It is possible that the other 4 methods in PropertyInfo are never referenced by
any of the other Derby code.

Another interesting thing is the class
org.apache.derbyTesting.functionTests.util.TestPropertyInfo

The TestPropertyInfo class appears to be almost a duplicate of the PropertyInfo class.

The comment of TestPropertyInfo.java says:

/**
 * This class extends PropertyInfo to provide support for viewing ALL
 * table/index properties, not just the user-visible ones.
 */

However, this is not true: TestPropertyInfo does NOT extend PropertyInfo.

Also, even though TestPropertyInfo's name and source tree location implies
that it is part of the Derby regression tests, I don't think it is actually part
of the live Derby test suites that are run regularly:
- TestPropertyInfo is not a JUnit test class or suite
- TestPropertyInfo does not appear in any of the RunSuite test suites

So, for now, these two classes are a puzzle to me, and further study is needed.
                
> Improve test coverage of org.apache.derby.iapi.db.PropertyInfo
> --------------------------------------------------------------
>
>                 Key: DERBY-6264
>                 URL: https://issues.apache.org/jira/browse/DERBY-6264
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Test
>            Reporter: Bryan Pendleton
>            Assignee: ahsan shamsudeen
>            Priority: Minor
>
> According to the coverage reports, only 1 of the 5 methods in
> org.apache.derby.iapi.db.PropertyInfo is exercised by the Derby
> regression tests.
> This sub-task is to improve that test coverage.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message