db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (DERBY-6262) Simplify message-generating methods using varargs
Date Tue, 18 Jun 2013 14:43:20 GMT

     [ https://issues.apache.org/jira/browse/DERBY-6262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Knut Anders Hatlen updated DERBY-6262:
--------------------------------------

    Attachment: derby-6262-02-a.diff

Thanks, Bryan.

derby-6262-02-a.diff further reduces the number of constructors in SqlException (6 constructors
are replaced by 2) and in DisconnectException (7 are replaced by 2).

Some of the removed constructors didn't have the Object[] argument last in the parameter list,
which is the only position in which varargs are allowed, so some reordering of arguments in
the callers was needed.

All regression tests ran cleanly.
                
> Simplify message-generating methods using varargs
> -------------------------------------------------
>
>                 Key: DERBY-6262
>                 URL: https://issues.apache.org/jira/browse/DERBY-6262
>             Project: Derby
>          Issue Type: Improvement
>          Components: Miscellaneous
>    Affects Versions: 10.11.0.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>            Priority: Minor
>         Attachments: derby-6262-01-a.diff, derby-6262-02-a.diff
>
>
> I've found that many methods that generate messages could be collapsed into a single
method using varargs. Right now, many of them exist in multiple variants, typically for zero
up to three or four message arguments.
> Examples:
>   Monitor.logTextMessage()
>   MessageService.getTextMessage()
>   Constructors in SqlException and SqlWarning

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message