db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-673) Get rid of the NodeFactory
Date Wed, 19 Jun 2013 12:57:24 GMT

    [ https://issues.apache.org/jira/browse/DERBY-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13687941#comment-13687941

Knut Anders Hatlen commented on DERBY-673:

Thanks for the patch, Dag. I think this is a good improvement, as it makes a whole class of
errors detectable at compile time.

I did go through the patch, but because of the size of it, I must admit that I didn't study
each line very carefully. But my impression was that the changes looked reasonable. So +1
from me.

In some parts of the patch, it looked like the only changes were renaming of variables, like
operator -> op, methodName -> mNam or methodNam, exposedName -> exposedNam, costEstimate
-> costEst. I think I prefer the old names, but not so much that I think it should block
the commit. No, wait... Maybe these were the variables you referred to in (d) in the patch
description? OK, that's a good enough reason for renaming them, I would suppose.

> Get rid of the NodeFactory
> --------------------------
>                 Key: DERBY-673
>                 URL: https://issues.apache.org/jira/browse/DERBY-673
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL
>            Reporter: Rick Hillegas
>            Assignee: Dag H. Wanvik
>         Attachments: derby-673-1.diff.gz, derby-673-1.status, nodefactory-31.status,
> This piece of code once had a purpose in life. It was one of the double-joints which
allowed cloudscape to ship with and without compiler support for the synchronization language.
Synchronization has been removed. If we want to plug in optional language components, I think
there are better ways to do this.
> The NodeFactory turned into a big, sprawling piece of code. At some point this code was
slimmed down by telescoping all of its factory methods into a couple unwieldly, weakly-typed
overloads backed by cumbersome logic in the actual node constructors. I would like to reintroduce
strongly typed node constructors which the parser can call directly. This will make node generation
easier to read and less brittle and it will get rid of the now useless NodeFactory class.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message