db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (DERBY-6169) Reduce visibility of classes and methods under impl/sql
Date Wed, 08 May 2013 12:29:16 GMT

     [ https://issues.apache.org/jira/browse/DERBY-6169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Knut Anders Hatlen updated DERBY-6169:
--------------------------------------

    Attachment: derby-6169-12-a.diff

Attaching derby-6169-12-a.diff which reduces the visibility of more methods and fields in
impl/sql/compile that expose package-private classes outside the package.

The patch also removes the unused DeleteNode.fkInfo field and the unused ResultColumn.generateHolder()
method.

All tests ran cleanly.
                
> Reduce visibility of classes and methods under impl/sql
> -------------------------------------------------------
>
>                 Key: DERBY-6169
>                 URL: https://issues.apache.org/jira/browse/DERBY-6169
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 10.11.0.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>            Priority: Minor
>         Attachments: derby-6169-01-a.diff, derby-6169-02-a.diff, derby-6169-03-a.diff,
derby-6169-04-a.diff, derby-6169-05-a.diff, derby-6169-06-a.diff, derby-6169-06-b.diff, derby-6169-07-a.diff,
derby-6169-08-a.diff, derby-6169-09-a.diff, derby-6169-10-a.diff, derby-6169-11-a.diff, derby-6169-12-a.diff
>
>
> My IDE shows many warnings in the classes under impl/sql because they are public and
may make parts of the internal state more visible than necessary. I'd like to reduce the visibility
of classes and methods, if possible, to make it clearer to IDEs and tools that perform static
analysis that the code is only accessed from the same package, and reduce some of the noise
from the tools.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message