db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (DERBY-5840) Clean up compiler warnings introduced by using Java 5 language features
Date Fri, 24 May 2013 12:22:21 GMT

     [ https://issues.apache.org/jira/browse/DERBY-5840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Knut Anders Hatlen updated DERBY-5840:

    Attachment: derby-5840-23-aa-parsers.diff

The build script post-processes the parsers generated by JavaCC and inserts @SuppressWarnings("unchecked")
to silence the compiler.

JavaCC has a JDK_VERSION option, and when it's set to "1.5" it produces code that compiles
cleanly. (I also tried with "1.6", but our version of JavaCC is too old to recognize that

The attached patch, derby-5840-23-aa-parsers.diff, sets JDK_VERSION = "1.5" in all the jj
files and removes the post-processing target from the build script.

The code compiles without warnings with the patch. I'm running regression tests.
> Clean up compiler warnings introduced by using Java 5 language features
> -----------------------------------------------------------------------
>                 Key: DERBY-5840
>                 URL: https://issues.apache.org/jira/browse/DERBY-5840
>             Project: Derby
>          Issue Type: Improvement
>          Components: Miscellaneous
>    Affects Versions:
>            Reporter: Rick Hillegas
>         Attachments: derby-5840-01-aa-compatibilityTests.diff, derby-5840-02-aa-compatibilityTests-again.diff.txt,
derby-5840-03-aa-drda.diff, derby-5840-03-ab-drda.diff, derby-5840-04-aa-client-level.diff,
derby-5840-05-aa-client-deprecation.diff, derby-5840-06-aa-jdbc3-stubs.diff, derby-5840-07-aa-drda-for-each.diff,
derby-5840-08-aa-jdbc3-embedded.diff, derby-5840-09-aa-test-deprecation-and-unchecked.diff,
derby-5840-10-aa-derbynet-perf-system.diff, derby-5840-11-aa-engine-i18n-store-tools.diff,
derby-5840-12-aa-jdbcapi.diff, derby-5840-13-aa.diff, derby-5840-13-aa-remove-suppression.diff,
derby-5840-14-aa-bigdecimal.diff, derby-5840-15-aa-more-suppressions.diff, derby-5840-16-aa-class-size-catalog.diff,
derby-5840-17-aa-property-conglomerate.diff, derby-5840-18-aa-arrayutil.diff, derby-5840-19-aa-ddutils.diff,
derby-5840-20-aa-collectnodes.diff, derby-5840-21-aa-arrays.diff, derby-5840-22-aa-grouped-aggregates.diff,
> Using Java 5 language features forces us to compile code at level 5 or higher. At this
level, the compiler raises warnings not seen at lower levels. This issue is a place to discuss
and attach cleanup to eliminate these warnings.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message