db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (DERBY-5840) Clean up compiler warnings introduced by using Java 5 language features
Date Fri, 24 May 2013 11:40:21 GMT

     [ https://issues.apache.org/jira/browse/DERBY-5840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Knut Anders Hatlen updated DERBY-5840:

    Attachment: derby-5840-22-aa-grouped-aggregates.diff

derby-5840-22-aa-grouped-aggregates.diff removes a SuppressWarnings annotation from GroupedAggregateResultSet
and fixes the suppressed warning. It was caused by unchecked conversions when getting HashSet<String>
instances from a two-dimensional array of HashSets. The fix was to change the type of the
distinctValues field from HashSet[][] to List<List<Set<String>>>, as collections
can have generic types whereas arrays cannot.

While making this change, I found some suspicious-looking logic in the duplicate handling
and filed DERBY-6227.
> Clean up compiler warnings introduced by using Java 5 language features
> -----------------------------------------------------------------------
>                 Key: DERBY-5840
>                 URL: https://issues.apache.org/jira/browse/DERBY-5840
>             Project: Derby
>          Issue Type: Improvement
>          Components: Miscellaneous
>    Affects Versions:
>            Reporter: Rick Hillegas
>         Attachments: derby-5840-01-aa-compatibilityTests.diff, derby-5840-02-aa-compatibilityTests-again.diff.txt,
derby-5840-03-aa-drda.diff, derby-5840-03-ab-drda.diff, derby-5840-04-aa-client-level.diff,
derby-5840-05-aa-client-deprecation.diff, derby-5840-06-aa-jdbc3-stubs.diff, derby-5840-07-aa-drda-for-each.diff,
derby-5840-08-aa-jdbc3-embedded.diff, derby-5840-09-aa-test-deprecation-and-unchecked.diff,
derby-5840-10-aa-derbynet-perf-system.diff, derby-5840-11-aa-engine-i18n-store-tools.diff,
derby-5840-12-aa-jdbcapi.diff, derby-5840-13-aa.diff, derby-5840-13-aa-remove-suppression.diff,
derby-5840-14-aa-bigdecimal.diff, derby-5840-15-aa-more-suppressions.diff, derby-5840-16-aa-class-size-catalog.diff,
derby-5840-17-aa-property-conglomerate.diff, derby-5840-18-aa-arrayutil.diff, derby-5840-19-aa-ddutils.diff,
derby-5840-20-aa-collectnodes.diff, derby-5840-21-aa-arrays.diff, derby-5840-22-aa-grouped-aggregates.diff
> Using Java 5 language features forces us to compile code at level 5 or higher. At this
level, the compiler raises warnings not seen at lower levels. This issue is a place to discuss
and attach cleanup to eliminate these warnings.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message