Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Date: Sat, 13 Apr 2013 14:02:15 +0000 (UTC)
From: "Dag H. Wanvik (JIRA)" <jira@apache.org>
To: derby-dev@db.apache.org
Message-ID: <JIRA.12642044.1365690537932.163250.1365861735710@arcas>
In-Reply-To: <JIRA.12642044.1365690537932@arcas>
References: <JIRA.12642044.1365690537932@arcas>
Subject: [jira] [Commented] (DERBY-6169) Reduce visibility of classes and
 methods under impl/sql
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/DERBY-6169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13631050#comment-13631050 ] 

Dag H. Wanvik commented on DERBY-6169:
--------------------------------------

derby-6169-01-a look good to me. +1
                
> Reduce visibility of classes and methods under impl/sql
> -------------------------------------------------------
>
>                 Key: DERBY-6169
>                 URL: https://issues.apache.org/jira/browse/DERBY-6169
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 10.11.0.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>            Priority: Minor
>         Attachments: derby-6169-01-a.diff, derby-6169-02-a.diff
>
>
> My IDE shows many warnings in the classes under impl/sql because they are public and may make parts of the internal state more visible than necessary. I'd like to reduce the visibility of classes and methods, if possible, to make it clearer to IDEs and tools that perform static analysis that the code is only accessed from the same package, and reduce some of the noise from the tools.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira