Return-Path: X-Original-To: apmail-db-derby-dev-archive@www.apache.org Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DA39AF023 for ; Mon, 29 Apr 2013 07:14:18 +0000 (UTC) Received: (qmail 4290 invoked by uid 500); 29 Apr 2013 07:14:18 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 4094 invoked by uid 500); 29 Apr 2013 07:14:17 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 4006 invoked by uid 99); 29 Apr 2013 07:14:15 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 Apr 2013 07:14:15 +0000 Date: Mon, 29 Apr 2013 07:14:15 +0000 (UTC) From: "Dag H. Wanvik (JIRA)" To: derby-dev@db.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (DERBY-6125) Code clean up in client driver. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DERBY-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dag H. Wanvik updated DERBY-6125: --------------------------------- Attachment: derby-6125-visibility-02-d.diff derby-6125-visibility-02-d.status Uploading a new patch, derby-6125-visibility-02-d which further limits scopes program entities and also removed dead code, inclusing maintenance of fields that are never read, i.e. used for anything except setting them. When I use the term "unused" below it may mean that something is ultimately unused, e.g a method used to set an unused field, or due to other code removal transitively. * Agent Removed unused method batchUpdateExceptionGenerated * ClientCallableStatement Removed two unused overloads: resetCallableStatement * ClientClob Removed unused field encoding_ Removed unused methods createClobWrapper, convertFromAsciiToCharacterStream * ClientPreparedStatement Removed unused methods resetPreparedStatement, initPreparedStatement, writeDescribeOutput, readDescribeOutput, writePrepareDescribeInputOutput, checkScaleForINOUTDecimal Inlined creation of method not implemented exception, removed jdbc3FeatureNotSupported. * ClientResultSet Commented out unused fields updatability_unknown__, updatability_readOnly__ Removed unused fields NEXT_ROWSET, PREVIOUS_ROWSET, ABSOLUTE_ROWSET, FIRST_ROWSET, LAST_ROWSET, RELATIVE_ROWSET, REFRESH_ROWSET, nestingLevel_ Removed unused method rowCountIsKnown. flowFetch moved to NetResultSet. * ClientStatement Removed unused field returnValueFromProcedure_ Commented out unused fields isCommitSql__, isRollbackSql__, isPositionedUpdateDeleteSql__ Removed unused method clientmarkResultSetsClosed, getProcedureName, upperCaseProcedureName, jdbc3FeatureNotSupported * ClobLocatorOutputStream Removed unused field connection * ColumnMetaData Removed unused fields singleMixedByteOrDouble_, protocolTypeToOverrideLidMapping_, mddOverrideArray_ Removed unused method isParameterModeGuessedAsOutput, columnIsNotInUnicode * Configuration Removed unused fields jreLevelMajor, jreLevelMinor, jreLevel, dncPackageVersion, enableNetConnectionPooling, cursorAttribute_InsensitiveRowset, cursorAttribute_SensitiveDynamicRowset, cursorAttribute_InsensitiveRowset * CrossConverters Removed unused method getBooleanFromByte, getBigDecimalFromBoolean, getStringFromBoolean, getDateFromTime(Time), getDateFromTimestamp(Timestamp), getTimeFromTimestamp(Timestamp), getTimestampFromTime(Time), getTimestampFromDate(Date) * DisconnectException Removed unused constructor DisconnectException(Agent, ClientMessageId, SqlCode) * LogWriter Removed unused traceExit overloads. * SectionManager Removed unused fields collection_, HOLD, NO_HOLD, * SqlCode Removed unused fields invalidCommitOrRollbackUnderXA, invalidSetAutoCommitUnderXA, undefinedError * SqlException Removed unused constructor SqlException(LogWriter, ClientMessageId, SqlCode) * SqlWarning Removed unused constructors Removed unused method getNextWarning * Sqlca Removed unused methods getReturnValue, includesSqlCode * Utils Removed unused methods getStringFromStrings, padOrTruncate, checkForNegativePositiveSqlcard (2X), getUpdateCountFromSqlcard, accumulateSQLWarning, getSQLTypeName (we might want to keep this for debugging possibly?) * Version Removed unused methods getDriverName, getBuildNumber, isAlpha, isBeta * XaException Removed unused constructors Removed unused method copyAsUnchainedXAException * CodePoint Removed many unused code points (fields). One could argue that it's nice to keep these if we need them later, opinions welcomed. For me it seems clearer to only keep those we need, we know what the source for the constants is anyway, i.e. the DRDA specification. * DssConstants Removed many unused constants, cf previous item considerations. * FdocaConstants Removed many unused constants, cf previous item considerations. * FdocaSimpleDataArray Removed unused fields fdocaFieldType_, representation_, mode_, fieldLength_ * NetAgent Removed unused fields packageRequest_, Removed unused method convertToStringTcpIpAddress * NetConfiguration Removed unused fields INITIAL_CAPACITY, NON_CHAR_DDM_DATA_PAD_BYTE, CURSOR_NOT_OPEN, CURSOR_OPEN, CURSOR_CLOSE_ONLY, DDMHDR_LENGTH, PRDDTA_MAX_ACCT_SUFFIX_LEN, MGRLVL_3, MGRLVL_4, MGRLVL_6, SECMEC_DCESEC, SECMEC_EUSRIDNWPWD, SYSTEM_ASC * NetConnection Removed unused field pendingEndXACallinfoOffset_, targetSrvclsnm_, seqNo_ Removed unused methods getSpecialRegisters, addSpecialRegisters, getSequenceNumber, getIndoubtTransaction, doResetNow, serverSupportsBooleanValues * NetConnectionRequest Removed unused method writeDummyExchangeServerAttributes * NetCursor Removed unused fields targetSqlamForTypdef_, numMddOverrides_ * NetResultSet Removed unused method queryDataWasReturnedOnOpen * NetResultSet Method flowFetch moved from ClientResultSet to be able to make it package private. * NetStatement Removed unused constructor Removed unused method netReset * NetXACallInfo Removed unused fields xaInProgress_, xaWasSuspended, currConnection_, freeEntry_, convReleased_, xaResource_, uowid_, readOnlyTransaction_ Removed unused methods setUOWID, getUOWID, setReadOnlyTransactionFlag, getReadOnlyTransactionFlag * NetXAConnection Removed unused methods writeLocalXAStart_, readLocalXAStart, getUOWID, getPort * NetXAResource Removed unused fields TMTIMEOUT, ACTIVE_ONLY, XA_NULL_XID, RECOVER_XID_ARRAY_LENGTH, XAFUNC_NONE, rmId_, numXACallInfo_, connectionCount_, activeXATransCount_, rmIdx_, rmIdy_, port_, ipaddr_, specialRegisters_ Removed unused methods throwXAException, getSpecialRegisters, addSpecialRegisters * Reply Removed unused fields dssIsChainedWithDiffID_ Removed unused methods readIntArray, readLong, readBoolean, readString(int), readLDBytes, peekLength * Request Removed unused method createXACommand, writeScalarBytes, writeScalarHeader, writeScalarPaddedBytes, writeDDMString * Typdef Removed unused constructor(NetAgent, int, String) Removed unused field environment_ Removed unused methods clearCcsidSbc, clearCcsidDbc, clearCcsidMbc * NetIndoubtTransaction removed altogether > Code clean up in client driver. > ------------------------------- > > Key: DERBY-6125 > URL: https://issues.apache.org/jira/browse/DERBY-6125 > Project: Derby > Issue Type: Improvement > Components: Network Client > Reporter: Dag H. Wanvik > Attachments: derby-6125-01-a.diff, derby-6125-01-b.diff, derby-6125-01-b.status, derby-6125-02-a.diff, derby-6125-02-a.status, derby-6125-03-04-followup.diff, derby-6125-03-04-followup.status, derby-6125-03-a.diff, derby-6125-03-a.status, derby-6125-04-a.diff, derby-6125-04-a.status, derby-6125-05-a.diff, derby-6125-05-c.diff, derby-6125-05-c.status, derby-6125-05-d.diff, derby-6125-05-d.status, derby-6125-imports-01-a.diff, derby-6125-imports-01-a.status, derby-6125-rename-01-c.diff.gz, derby-6125-rename-01-c.stat, derby-6125-visibility-01-a.diff, derby-6125-visibility-01-a.status, derby-6125-visibility-01-b.diff, derby-6125-visibility-02-d.diff, derby-6125-visibility-02-d.status > > > Clean up unused code, lacking finals, too wide visibility etc. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira