Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Date: Sun, 14 Apr 2013 04:22:16 +0000 (UTC)
From: "Dag H. Wanvik (JIRA)" <jira@apache.org>
To: derby-dev@db.apache.org
Message-ID: <JIRA.12638453.1363938633719.164404.1365913336205@arcas>
In-Reply-To: <JIRA.12638453.1363938633719@arcas>
References: <JIRA.12638453.1363938633719@arcas>
Subject: [jira] [Commented] (DERBY-6125) Code clean up in client driver.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/DERBY-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13631265#comment-13631265 ] 

Dag H. Wanvik commented on DERBY-6125:
--------------------------------------

Committed derby-6125-imports-01-a plus I removed the vacuous @throws as Knut suggested.

Commit message:

derby-6125-imports-01-a. This "horizontal" patch makes the import
    policy consistent for the client driver:
    
    - iff a class from java.sql.* can be shadowed by a Derby class
      (i.e. Clob, ResultSet); we do not import such java.sql.* classes but
      refer to them using the full package and class name. The Derby
      classes are always imported and referenced in the short form. This
      makes the code much more readable IMHO.
    
    - I'd like to change the names of the Derby classes that can shadow
      java.sql.* classes (so we can import such classes from java.sql.*
      too), but I need to investigate whether that can have any
      compatibility issues first. Does anyone know?
    
    - removes unused public static variable ClientXid#MAXGTRIDSIZE
    
    - removes a few unused initial values to silence NetBeans warnings
    
    - removes unused Cursor#getUnicodeStream
    
    Otherwise, the patch contains a few Javadoc improvements and typo
    fixes.
                
> Code clean up in client driver.
> -------------------------------
>
>                 Key: DERBY-6125
>                 URL: https://issues.apache.org/jira/browse/DERBY-6125
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Client
>            Reporter: Dag H. Wanvik
>         Attachments: derby-6125-01-a.diff, derby-6125-01-b.diff, derby-6125-01-b.status, derby-6125-02-a.diff, derby-6125-02-a.status, derby-6125-03-04-followup.diff, derby-6125-03-04-followup.status, derby-6125-03-a.diff, derby-6125-03-a.status, derby-6125-04-a.diff, derby-6125-04-a.status, derby-6125-05-a.diff, derby-6125-05-c.diff, derby-6125-05-c.status, derby-6125-05-d.diff, derby-6125-05-d.status, derby-6125-imports-01-a.diff, derby-6125-imports-01-a.status, derby-6125-visibility-01-a.diff, derby-6125-visibility-01-a.status, derby-6125-visibility-01-b.diff
>
>
> Clean up unused code, lacking finals, too wide visibility etc.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira