db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rick Hillegas (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (DERBY-6206) Cleanup suspect coding practices in misc Derby packages
Date Tue, 30 Apr 2013 14:26:15 GMT

     [ https://issues.apache.org/jira/browse/DERBY-6206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Rick Hillegas updated DERBY-6206:

    Attachment: derby-6206-07-aa-BaseActivation.diff

Attaching derby-6206-07-aa-BaseActivation.diff. This patch fixes some mutability problems
in BaseActivation. I am running tests now.

Two changes are made:

1) A method which used to return a mutable Hashtable now just returns an enumeration through
its keys. It turns out that the callers only needed the keys.

2) Some arrays are copied. This copying happens during the initialization phase of statement
execution, not on the inner looping through rows.

Touches the following files:


M       java/engine/org/apache/derby/iapi/sql/Activation.java
M       java/engine/org/apache/derby/impl/sql/execute/DeleteCascadeResultSet.java
M       java/engine/org/apache/derby/impl/sql/GenericActivationHolder.java

Changes for (1).


M       java/engine/org/apache/derby/impl/sql/execute/InsertResultSet.java

Cleanup to avoid materializing redundant copies of copies.


M       java/engine/org/apache/derby/impl/sql/execute/BaseActivation.java

Changes for (1) and (2).


M       java/engine/org/apache/derby/impl/jdbc/EmbedStatement.java

Changes for (2).

> Cleanup suspect coding practices in misc Derby packages
> -------------------------------------------------------
>                 Key: DERBY-6206
>                 URL: https://issues.apache.org/jira/browse/DERBY-6206
>             Project: Derby
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions:
>            Reporter: Rick Hillegas
>            Assignee: Rick Hillegas
>            Priority: Minor
>         Attachments: derby-6206-01-aa-NetworkServerControlImpl.diff, derby-6206-02-aa-ExecutionContext.diff,
derby-6206-03-aa-XPLAIN.diff, derby-6206-04-aa-implJDBC.diff, derby-6206-04-ab-implJDBC.diff,
derby-6206-05-aa-implSQL.diff, derby-6206-06-aa-GenericResultDescription.diff, derby-6206-07-aa-BaseActivation.diff
> Similar to DERBY-6177.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message