db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rick Hillegas (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (DERBY-6188) Cleanup suspect coding practices in org.apache.derby.iapi.services.io package
Date Fri, 19 Apr 2013 14:25:16 GMT

     [ https://issues.apache.org/jira/browse/DERBY-6188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Rick Hillegas updated DERBY-6188:
---------------------------------

    Attachment: derby-6188-01-ab-formatables.diff

Attaching derby-6188-01-ab-formatables.diff. This patch cleans up some array-related encapsulation
problems in the Formatable machinery. I am running tests now.


Touches the following files:

------------------

M       java/engine/org/apache/derby/iapi/services/io/ArrayUtil.java

Added a new copy() overload to handle byte arrays.

------------------

M       java/engine/org/apache/derby/iapi/services/io/RegisteredFormatIds.java
M       java/engine/org/apache/derby/iapi/types/DataValueFactoryImpl.java
M       java/engine/org/apache/derby/impl/services/monitor/BaseMonitor.java

Made the array of formatable classes private and added some accessors.

------------------

M       java/engine/org/apache/derby/iapi/services/io/FormatableBitSet.java
M       java/engine/org/apache/derby/impl/sql/depend/BasicDependencyManager.java
M       java/testing/org/apache/derbyTesting/unitTests/junit/FormatableBitSetTest.java
M       java/testing/org/apache/derbyTesting/junit/BaseTestCase.java

Copy bit arrays in FormatableBitSet's constructor and accessors.

                
> Cleanup suspect coding practices in org.apache.derby.iapi.services.io package
> -----------------------------------------------------------------------------
>
>                 Key: DERBY-6188
>                 URL: https://issues.apache.org/jira/browse/DERBY-6188
>             Project: Derby
>          Issue Type: Bug
>          Components: Services
>    Affects Versions: 10.11.0.0
>            Reporter: Rick Hillegas
>            Assignee: Rick Hillegas
>            Priority: Minor
>         Attachments: derby-6188-01-ab-formatables.diff
>
>
> Similar to DERBY-6177.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message