db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (DERBY-6186) SYSTRIGGERSRowFactory should use DataDescriptorGenerator to build descriptor
Date Wed, 17 Apr 2013 14:05:16 GMT

     [ https://issues.apache.org/jira/browse/DERBY-6186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Knut Anders Hatlen updated DERBY-6186:

    Attachment: derby-6186-01-a.diff

The attached patch makes the suggested changes, as well as removing some unused imports and
making UserDescriptor's constructor package private.

All the regression tests ran cleanly with the patch.
> SYSTRIGGERSRowFactory should use DataDescriptorGenerator to build descriptor
> ----------------------------------------------------------------------------
>                 Key: DERBY-6186
>                 URL: https://issues.apache.org/jira/browse/DERBY-6186
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions:
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>            Priority: Trivial
>         Attachments: derby-6186-01-a.diff
> SYSTRIGGERSRowFactory.buildDescriptor() creates a descriptor by calling TriggerDescriptor's
constructor directly. It already has a DataDescriptorGenerator instance, so it should instead
call the newTriggerDescriptor(). This would allow TriggerDescriptor's constructor to become
package protected, which improves encapsulation.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message