db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rick Hillegas (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (DERBY-6177) Cleanup suspect coding practices in org.apache.derby.catalog.types
Date Fri, 12 Apr 2013 17:00:18 GMT

     [ https://issues.apache.org/jira/browse/DERBY-6177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Rick Hillegas updated DERBY-6177:
---------------------------------

    Attachment: derby-6177-01-aa-copyArrays.diff

Attaching derby-6177-01-aa-copyArrays.diff. This patch creates copies of arrays in various
constructors and accessor methods. I am running tests now.

Touches the following files:

----------------

M       java/engine/org/apache/derby/iapi/services/io/ArrayUtil.java

Added some utility methods for copying arrays.

----------------

M       java/engine/org/apache/derby/catalog/types/TypeDescriptorImpl.java
M       java/engine/org/apache/derby/catalog/types/RoutineAliasInfo.java
M       java/engine/org/apache/derby/catalog/types/RowMultiSetImpl.java
M       java/engine/org/apache/derby/catalog/types/DefaultInfoImpl.java
M       java/engine/org/apache/derby/catalog/types/ReferencedColumnsDescriptorImpl.java
M       java/engine/org/apache/derby/catalog/types/IndexDescriptorImpl.java

Used the new utility methods to copy arrays inside constructors and accessor methods.

                
> Cleanup suspect coding practices in org.apache.derby.catalog.types
> ------------------------------------------------------------------
>
>                 Key: DERBY-6177
>                 URL: https://issues.apache.org/jira/browse/DERBY-6177
>             Project: Derby
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 10.11.0.0
>            Reporter: Rick Hillegas
>            Priority: Minor
>         Attachments: derby-6177-01-aa-copyArrays.diff
>
>
> Cleanup suspect coding practices such as accessor methods returning mutable objects which
can be corrupted by callers.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message