db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-6162) Simplify privileged actions in NetworkServerControlApiTest
Date Wed, 10 Apr 2013 15:12:16 GMT

    [ https://issues.apache.org/jira/browse/DERBY-6162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13627885#comment-13627885
] 

Knut Anders Hatlen commented on DERBY-6162:
-------------------------------------------

Thanks, Dag.

We also use the -Xlint option when compiling the client code and the JDBC 4.x test code. Maybe
not a convention, but at least it's not unprecedented. I found it useful to add it so that
I didn't have to recompile manually in order to find out what was causing a warning. Without
the flag, the compiler says there are warnings, but doesn't give any details about where and
why.

Committed revision 1466508.
                
> Simplify privileged actions in NetworkServerControlApiTest
> ----------------------------------------------------------
>
>                 Key: DERBY-6162
>                 URL: https://issues.apache.org/jira/browse/DERBY-6162
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>    Affects Versions: 10.11.0.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>            Priority: Trivial
>         Attachments: d6162-1a.diff
>
>
> Noticed two privileged blocks in NetworkServerControlApiTest that could be simplified:
> - privInetAddressGetByName() tests whether the PrivilegedActionException wraps a SecurityException.
PAE only wraps checked exceptions, and SecurityException is an unchecked exception, so that
can never happen.
> - fileExists() could use the existing helper method PrivilegedFileOpsForTests.exists()
and remove its privileged block.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message