db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (DERBY-6161) Simplify code that handles LOB files
Date Wed, 10 Apr 2013 08:44:16 GMT

     [ https://issues.apache.org/jira/browse/DERBY-6161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Knut Anders Hatlen updated DERBY-6161:
--------------------------------------

    Attachment: d6161-1a.diff

Attaching d6161-1a.diff which makes the following changes:

- Fix typos and misformatted @throws clauses in javadoc comments.

- Remove unnecessary override of close() in EncryptedLOBFile (it only calls super.close(),
so it could just as well inherit the method).

- Privileged block in LOBStreamControl.init() contains code that doesn't need privileges.
Move that code out of the privileged block. Since that code could throw StandardException
and the remaining code in the block can only throw IOException, this also allowed simplification
of the exception handling.

- Privileged block in LOBStreamControl.deleteFile() cannot throw checked exception, so use
PrivilegedAction instead of PrivilegedExceptionAction. This allowed removal of the exception
handling code.

All the regression tests ran cleanly with the patch.
                
> Simplify code that handles LOB files
> ------------------------------------
>
>                 Key: DERBY-6161
>                 URL: https://issues.apache.org/jira/browse/DERBY-6161
>             Project: Derby
>          Issue Type: Improvement
>          Components: JDBC
>    Affects Versions: 10.10.1.1
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>            Priority: Minor
>         Attachments: d6161-1a.diff
>
>
> When investigating DERBY-6092, I found some code that could be simplified/cleaned up.
Will make those changes here.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message