db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-6125) Code clean up in client driver.
Date Tue, 02 Apr 2013 07:05:15 GMT

    [ https://issues.apache.org/jira/browse/DERBY-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13619579#comment-13619579

Knut Anders Hatlen commented on DERBY-6125:

The 03-a and 04-a patches have added getter methods for some static arrays in order to return
a copy rather than a direct reference to the array. I think these methods could be simplified
to just returning array.clone() instead of manually creating a new array and copying the contents
into it.

NetConnection.completeConnect() was made final in 04-a, but that method doesn't actually do
anything except calling super.completeConnect(). Remove the override and make the super method
final instead?
> Code clean up in client driver.
> -------------------------------
>                 Key: DERBY-6125
>                 URL: https://issues.apache.org/jira/browse/DERBY-6125
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Client
>            Reporter: Dag H. Wanvik
>         Attachments: derby-6125-01-a.diff, derby-6125-01-b.diff, derby-6125-01-b.status,
derby-6125-02-a.diff, derby-6125-02-a.status, derby-6125-03-a.diff, derby-6125-03-a.status,
derby-6125-04-a.diff, derby-6125-04-a.status, derby-6125-05-a.diff
> Clean up unused code, lacking finals, too wide visibility etc.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message